openbsd/src/lib/libcrypto/ts/ts_lib.c, branch OPENBSD_7_9

Replace trivial uses of ASN1_STRING_data()

2025-12-05T14:19:27+00:00

Almost entirely mechanical diff that ensures that for read-only accesses we use the const correct ASN1_STRING_get0_data(). Arguably, in most places the better fix would be to reach into ASN1_STRING but then we have to think and bikeshed... ok beck kenjiro

Rewrite TS_ASN1_INTEGER_print_bio()

2025-01-07T14:22:19+00:00

This eliminates another stupid BN_free(&bn) and uses BIO_printf() rather than a ludicrously silly result dance. In fact it appears that this dance was so hard to grok that OpenSSL misread it and made this function return the value -1 on ASN1_INTEGER_to_BN() failure, a value that it had never returned before. It doesn't matter anyway. The only uses of this function are internal to OpenSSL's code and since TS fully conforms to OpenSSL's high QA standards, no caller checks the return of TS_ASN1_INTEGER_print_bio(). ok jsing

Hide symbols in ts

2023-07-07T07:25:21+00:00

ok jsing@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Add #include "bn_lcl.h" to the files that will soon need it.

2021-12-04T16:08:32+00:00

ok inoguchi jsing

Move the now internal X.509-related structs into x509_lcl.h.

2021-11-01T20:53:08+00:00

Garbage collect the now unused LIBRESSL_CRYPTO_INTERNAL and LIBRESSL_OPAQUE_X509. Include "x509_lcl.h" where needed and fix a couple of unnecessary reacharounds. ok jsing

Replace remaining M_ASN1_STRING_* macros with calls to ASN1_STRING_*.

2015-09-10T14:29:22+00:00

This is not the same as the macro expansion, however the ASN1_STRING_* functions do match the macro expansions. ok doug@ miod@

Expand obsolete M_ASN1.*(cmp|dup|print|set) macros - no change in generated

2015-07-29T14:58:34+00:00

assembly. ok bcook@

Only import cryptlib.h in the four source files that actually need it.

2014-07-11T08:44:49+00:00

Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@

Stop including standard headers via cryptlib.h - pull in the headers that

2014-07-10T13:58:23+00:00

are needed in the source files that actually require them. ok beck@ miod@