openbsd/src/lib/libcrypto/ts/ts_verify_ctx.c, branch OPENBSD_7_9A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_92025-12-05T14:19:27+00:00Replace trivial uses of ASN1_STRING_data()2025-12-05T14:19:27+00:00tb2025-12-05T14:19:27+00:00urn:sha1:9d2d9214b79d3c58a92235befe0378b7ada96773
Almost entirely mechanical diff that ensures that for read-only accesses
we use the const correct ASN1_STRING_get0_data(). Arguably, in most
places the better fix would be to reach into ASN1_STRING but then we
have to think and bikeshed...
ok beck kenjiro
Use err_local.h rather than err.h in most places2025-05-10T05:54:39+00:00tb2025-05-10T05:54:39+00:00urn:sha1:41e8f99dd1625a9f0c80ce9d4383e95b18e85709
ok jsing
Hide symbols in ts2023-07-07T07:25:21+00:00beck2023-07-07T07:25:21+00:00urn:sha1:8ec0f288746ef0197965cf8c262dd2e89fba308e
ok jsing@
Remove TS_VERIFY_CTX_init()2023-04-25T17:52:54+00:00tb2023-04-25T17:52:54+00:00urn:sha1:ad8e5cf00f379430d2f0b02a2a3f2d39ad4093cbInline only use of TS_VERIFY_CTX_init()2023-03-31T17:47:39+00:00tb2023-03-31T17:47:39+00:00urn:sha1:2a8db15bfc3b623ee9b6183f1511ebe2cfc47335
Since TS_VERIFY_CTX is now opaque, the only thing TS_VERIFY_CTX_init()
is good for outside the library is memory leaks. Inside the library it's
also useless, since as a much more familiar name is memset(). It will soon
be able to join all the other nonsense that should never have leaked out of
this library.
Prepare to provide TS_VERIFY_CTX accessors2022-07-24T19:54:46+00:00tb2022-07-24T19:54:46+00:00urn:sha1:d8527f944e5dcafa2687d0ebff33a09f762af6e8
The setters make no sense since they do not free the old members and
return what was passed in instead of returning the old struct member
so that the caller has a chance of freeing them. This has the side
effect that calling a setter a second time will likely result in a leak.
TS_VERIFY_CTX_set_imprint() was "fixed" upstream by adding a free() but
the other three setters were missed since discussing the contributor's
CLA was more important. Also missed was that adding frees will result in
double frees: careful consumers like openssl/ruby have workarounds for
the strange existing semantics.
Add a compat #define for TS_VERIF_CTS_set_certs() that made it into the
public API with a typo.
A good illustration of the amount of thought and care that went into
the OpenSSL 1.1 API by both the implementers and the reviewers.
Amazing job overall.
We will be stuck with this nonsense for a long time.
ok jsing kn
Start making ts opaque2022-07-24T08:16:47+00:00tb2022-07-24T08:16:47+00:00urn:sha1:2fafe1cde355b3cfbb3b49badb99d5597b3f3fa5
Move the not yet exposed EssCertIDv2 struct internals to ts_local.h and move
the ASN.1 function prototypes that we don't want to expose with them.
Include ts_local.h where necessary or where it will be needed soon.
ok jsing
Send the function codes from the error functions to the bit bucket,2017-01-29T17:49:23+00:00beck2017-01-29T17:49:23+00:00urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
Remove assert() or OPENSSL_assert() of pointers being non-NULL. The policy2015-02-10T09:46:30+00:00miod2015-02-10T09:46:30+00:00urn:sha1:03858c0228d8ccda7d170fe43e0be79cd0dc6e5b
for libraries in OpenBSD is to deliberately let NULL pointers cause a SIGSEGV.
ok doug@ jsing@
Only import cryptlib.h in the four source files that actually need it.2014-07-11T08:44:49+00:00jsing2014-07-11T08:44:49+00:00urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@