openbsd/src/lib/libcrypto/ui/ui_lib.c, branch OPENBSD_7_9_BASE

Use err_local.h rather than err.h in most places

2025-05-10T05:54:39+00:00

ok jsing

libressl _namespace.h: adjust _ALIAS() to require a semicolon

2023-02-16T08:38:17+00:00

LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing

Consistently check for NULL early.

2022-12-23T02:31:56+00:00

Also be more consistent with variable naming. ok tb@

Fix an unchecked strdup() in UI_create_method().

2022-12-23T02:27:47+00:00

ok tb@

Make UI_destroy_method() NULL safe.

2022-12-23T02:26:16+00:00

ok tb@

Remove unhelpful comment.

2022-12-23T02:22:58+00:00

Remove a comment that tells you not to call a function that internally calls free, with a stack allocated pointer... ok tb@

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Hide symbols in libcrypto/ui

2022-11-12T13:16:10+00:00

ok jsing@

KNF for a few comments and indent a label

2020-09-25T11:25:31+00:00

Remove some dangling elses for consistency with the rest of the file

2020-09-25T11:17:52+00:00