openbsd/src/lib/libcrypto/ui, branch OPENBSD_7_3_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_3_BASE 2023-03-10T16:41:32+00:00 Expose UI_null() 2023-03-10T16:41:32+00:00 tb 2023-03-10T16:41:32+00:00 urn:sha1:6b84e5290af08a8f2fa2bd7a8638737c2f83a9ec libressl *_namespace.h: adjust *_ALIAS() to require a semicolon 2023-02-16T08:38:17+00:00 tb 2023-02-16T08:38:17+00:00 urn:sha1:24a27fd0d17d515b00097199de60fa85a76a95df LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing spelling fixes; from paul tagliamonte 2022-12-26T07:18:53+00:00 jmc 2022-12-26T07:18:53+00:00 urn:sha1:2eb7e5ff6bb69760f9dd4a43e7e3520ebb930120 i removed the arithmetics -> arithmetic changes, as i felt they were not clearly correct ok tb Consistently check for NULL early. 2022-12-23T02:31:56+00:00 jsing 2022-12-23T02:31:56+00:00 urn:sha1:1101e96e6f22cacf21188ce1c4b32487463d8dd2 Also be more consistent with variable naming. ok tb@ Fix an unchecked strdup() in UI_create_method(). 2022-12-23T02:27:47+00:00 jsing 2022-12-23T02:27:47+00:00 urn:sha1:cbeed38adefb3972a400e6b6880530e60ed498fa ok tb@ Make UI_destroy_method() NULL safe. 2022-12-23T02:26:16+00:00 jsing 2022-12-23T02:26:16+00:00 urn:sha1:a4db83fe8af01b2a889a2ee9ead4e6e1e230b54e ok tb@ Remove unhelpful comment. 2022-12-23T02:22:58+00:00 jsing 2022-12-23T02:22:58+00:00 urn:sha1:7012788d276e90efef561660cf0b47292d5c400a Remove a comment that tells you not to call a function that internally calls free, with a stack allocated pointer... ok tb@ Remove compatibility "glue" for des_read_pw{_string}() 2022-12-23T02:20:28+00:00 jsing 2022-12-23T02:20:28+00:00 urn:sha1:5d13674f48708547a95df6681a9681952e978bdc Nothing can be actually using these as the symbols are not exported from libcrypto... hopefully ui_compat.h can also go away entirely. ok tb@ Prepare to provide UI_null() 2022-12-17T21:59:39+00:00 tb 2022-12-17T21:59:39+00:00 urn:sha1:4b4b2e861fa5803efe93b65c639a868dee5d6325 xmlsec needs this, nothing else. Our linkers link libxmlsec1-openssl, only warns and since nothing uses this library in ports, this wasn't noticed for a long time. Reported by Thomas Mitterfellner ok jsing Make header guards of internal headers consistent 2022-11-26T17:23:18+00:00 tb 2022-11-26T17:23:18+00:00 urn:sha1:3a1908508efa61f3f77ac8036694af2f920df947 Not all of them, only those that didn't leak into a public header... Yes.