openbsd/src/lib/libcrypto/ui, branch libressl-v3.4.1

KNF for a few comments and indent a label

2020-09-25T11:25:31+00:00

Remove some dangling elses for consistency with the rest of the file

2020-09-25T11:17:52+00:00

Simplify UI_new_method()

2020-09-25T11:05:21+00:00

Use calloc() instead of malloc() and setting all members manually to 0. Avoid unnecessary else branch.

Move variable declaration to the top of UI_set_result and ditch

2020-09-25T10:56:36+00:00

a pointless local scope. suggested by jsing

The default branch of a switch somehow got moved inside of a pointless

2020-09-25T10:50:26+00:00

local scope of a case branch. Move it into the proper location. No binary change on amd64. "sure" jsing

Simplify call to ERR_print_errors_cb()

2020-09-25T10:46:12+00:00

There is no reason for print_error()'s third argument to be a UI *. It may just as well be a void * to match what ERR_print_errors_cb() expects. This avoids casting the function pointer. Also, there's no need for a (void *) cast. ok jsing

Error out if ok_chars and cancel_chars overlap

2020-09-24T19:31:01+00:00

It is a bit silly to push an error on the stack without erroring out, so error out if the ok_chars and cancel_chars overlap. ok jsing

Fix a number of leaks in the UI_dup_* functions

2020-09-24T19:29:09+00:00

If any of general_allocate_{prompt,string,boolean}() fail, the UI_dup_* functions may leak the strings they strduped beforehand. Instead, use strdup inside these functions, so we can free as necessary. This makes the UI_add_* and UI_dup_* simple wrappers around general_allocate_{string,boolean}() that differ only in passing a Boolean that indicates whether or not to use strdup. Make a general cleanup pass over these functions, simplify the logic and make it overall a bit easier to follow. While there, use strcspn() instead of a handrolled variant. The only changes in behavior are that ERR_R_MALLOC_FAILURE is now pushed onto the stack a bit more often and that UI_dup_input_string() now returns -1 on failure to dup prompt like all the other UI_dup_* functions. This is not a problem since the manual already documents that errors are signaled with <= 0. The only consumer of this function according to Debian's codesearch is libp11, I sent them a PR to fix their (already broken) error handling. Addresses about 10 errors thrown by the LLVM static analyzer in ui/. ok jsing

Push ERR_R_MALLOC_FAILURE onto the error stack

2020-09-24T19:24:45+00:00

If sk_UI_STRING_new_null() fails, this must be due to a memory error, so signal this to the user. ok jsing

Make free_strings() NULL safe

2020-09-24T19:22:18+00:00

ok jsing