openbsd/src/lib/libcrypto/ui, branch libressl-v4.1.2

const correct UI_OpenSSL()

2025-03-09T15:25:53+00:00

ok jsing

Garbage collec UI_UTIL remnants

2024-08-31T10:28:03+00:00

ok beck jsing

Neuter the completely broken UI_UTIL_read_pw* API

2024-08-24T07:50:23+00:00

Return 0 on success, return <= 0 on failure. Sigh. In particular, if an allocation failed, the password that no one entered was considered valid. ok jsing

Remove the empty ui_compat.h

2024-08-10T06:41:49+00:00

unused in ports and on codesearch

ui_util.c needs stdio.h and ui.h, but not ui_compat.h and ui_local.h

2024-08-08T09:56:51+00:00

libcrypto: constify most error string tables

2024-06-24T06:43:23+00:00

These constitute the bulk of the remaining global mutable state in libcrypto. This commit moves most of them into data.rel.ro, leaving out ERR_str_{functs,libraries,reasons} (which require a slightly different approach) and SYS_str_reasons which is populated on startup. The main observation is that if ERR_load_strings() is called with a 0 lib argument, the ERR_STRING_DATA argument is not actually modified. We could use this fact to cast away const on the caller side and be done with it. We can make this cleaner by adding a helper ERR_load_const_strings() which explicitly avoids the assignment to str->error overriding the error code already set in the table. In order for this to work, we need to sprinkle some const in err/err.c. CMS called ERR_load_strings() with non-0 lib argument, but this didn't actually modify the error data since it ored in the value already stored in the table. Annoyingly, we need to cast const away once, namely in the call to lh_insert() in int_err_set_item(). Fixing this would require changing the public API and is going to be tricky since it requires that the LHASH_DOALL_FN_* types adjust. ok jsing

Move some includes out of OPENSSL_NO_DEPRECATED

2023-04-18T08:33:43+00:00

Some headers were included conditionally on OPENSSL_NO_DEPRECATED in hopes that eventually the mess of everything includes everything will magically resolve itself. Of course everyone would end up building openssl with OPENSSL_NO_DEPRECATED over time... Right. Surprisingly, the ecosystem has come to rely on these implicit inclusions, so about two dozen ports would fail to build because of this. Patching this would be easy but really not worth the effort. ok jsing

Expose UI_null()

2023-03-10T16:41:32+00:00

libressl _namespace.h: adjust _ALIAS() to require a semicolon

2023-02-16T08:38:17+00:00

LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing

spelling fixes; from paul tagliamonte

2022-12-26T07:18:53+00:00

i removed the arithmetics -> arithmetic changes, as i felt they were not clearly correct ok tb