openbsd/src/lib/libcrypto/x509/x509_cmp.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2019-03-13T20:34:00+00:00 Fix a number of ASN1_INTEGER vs ASN1_STRING mixups coming from the 2019-03-13T20:34:00+00:00 tb 2019-03-13T20:34:00+00:00 urn:sha1:5ac8b80c66d7d9f6dab1bfdf23f0578eb05dffa0 mechanical M_ASN1 macro expansion. The ASN1_INTEGER_cmp function takes signs into account while ASN1_STRING_cmp doesn't. The mixups mostly involve serialNumbers, which, in principle, should be positive. However, it is unclear whether that is checked or enforced anywhere in the code, so these are probably bugs. Patch from Holger Mikolon ok jsing Provide X509_get0_serialNumber() 2018-08-24T19:59:32+00:00 tb 2018-08-24T19:59:32+00:00 urn:sha1:b2896b6759d33e259f8f56f743ec2d54f5002a50 tested in a bulk by sthen ok jsing Add const to both arguments of X509_check_private_key(3). 2018-05-18T19:24:08+00:00 tb 2018-05-18T19:24:08+00:00 urn:sha1:d7f54f2d9055851c59540a96dcf1a673fba160fc tested in a bulk build by sthen input & ok jsing Add const qualifier to the argument of X509_get_issuer_name(3) and 2018-05-13T10:36:35+00:00 tb 2018-05-13T10:36:35+00:00 urn:sha1:198462ba6ab3bc7513683c3a33b9d87b71378fa5 X509_get_subject_name(3). tested in a bulk build by sthen ok jsing (as part of a larger diff) Convert a handful of X509_*() functions to take const as in OpenSSL. 2018-05-01T19:01:28+00:00 tb 2018-05-01T19:01:28+00:00 urn:sha1:7c375c1a832336c8d9c706ebe1c9cd62252a1d88 tested in a bulk by sthen ok jsing Fix X509_get0_pubkey() - X509_get_pubkey() is a misnamed "get1" function, 2018-03-17T14:57:23+00:00 jsing 2018-03-17T14:57:23+00:00 urn:sha1:1febbbd02eb347551b033ef4c0195ac23c846521 so call X509_PUBKEY_get0() instead. Spotted by schwarze@ while documenting. Provide X509_chain_up_ref(). 2018-02-22T17:22:02+00:00 jsing 2018-02-22T17:22:02+00:00 urn:sha1:16ac06a4b0073b31d2e5be7dc5e12cde7a2f97ef From BoringSSL. Provide X509_get0_pubkey(). 2018-02-22T17:05:35+00:00 jsing 2018-02-22T17:05:35+00:00 urn:sha1:d21642ebf4b38bbc8f6b41c6767843209bed1c3f Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Expand obsolete M_ASN1.*(cmp|dup|print|set) macros - no change in generated 2015-07-29T14:58:34+00:00 jsing 2015-07-29T14:58:34+00:00 urn:sha1:2186614b2e5af6bbfcc1a9f8898ac11ea9c93faf assembly. ok bcook@