openbsd/src/lib/libcrypto/x509/x509_ext.c, branch OPENBSD_7_9_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE 2024-05-14T07:39:43+00:00 x509_ext.c: remove unnecessary includes 2024-05-14T07:39:43+00:00 tb 2024-05-14T07:39:43+00:00 urn:sha1:150ef7381379e0389f502c5a149c844eb583da96 x509_ext.c: remove lots of extraneous parentheses 2024-05-14T07:35:23+00:00 tb 2024-05-14T07:35:23+00:00 urn:sha1:28865b04425459ae9ab3b9c0f91c95ea5c45528f No change in the generated assembly libressl *_namespace.h: adjust *_ALIAS() to require a semicolon 2023-02-16T08:38:17+00:00 tb 2023-02-16T08:38:17+00:00 urn:sha1:24a27fd0d17d515b00097199de60fa85a76a95df LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing Make internal header file names consistent 2022-11-26T16:08:57+00:00 tb 2022-11-26T16:08:57+00:00 urn:sha1:81d98bf600a381a625eb11b39a725b08c0ba547f Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include <ssl_locl.h> was fixed manually. discussed with jsing, no objection bcook Hide public symbols in libcrypto/x509 .c files 2022-11-14T17:48:50+00:00 beck 2022-11-14T17:48:50+00:00 urn:sha1:86ef9af254717a5620d93d1ebe06ab2ad9597496 ok tb@ Move the now internal X.509-related structs into x509_lcl.h. 2021-11-01T20:53:08+00:00 tb 2021-11-01T20:53:08+00:00 urn:sha1:f478d62658b61e2242dbf3575bf454f8c0f432b1 Garbage collect the now unused LIBRESSL_CRYPTO_INTERNAL and LIBRESSL_OPAQUE_X509. Include "x509_lcl.h" where needed and fix a couple of unnecessary reacharounds. ok jsing Add const to the 'x' and 'obj' arguments of: 2018-05-18T19:28:27+00:00 tb 2018-05-18T19:28:27+00:00 urn:sha1:3837f48e35529be04679788d486c2082b24cfa6b X509_get_ext(3), X509_get_ext_by_NID(3), X509_get_ext_by_OBJ(3), X509_get_ext_by_critical(3), X509_get_ext_count(3), X509_get_ext_d2i(3). tested in a bulk by sthen ok jsing Add const qualifiers to the x and obj qualifiers of 2018-05-18T18:37:23+00:00 tb 2018-05-18T18:37:23+00:00 urn:sha1:51c5ab9e5435b41715f5ca9cc2ed04fe5aabb139 X509_REVOKED_get_ext(3), X509_REVOKED_get_ext_count(3), X509_REVOKED_get_ext_by_NID(3), X509_REVOKED_get_ext_by_OBJ(3), X509_REVOKED_get_ext_by_critical(3), X509_REVOKED_get_ext_d2i(3). tested in a bulk build by sthen ok jsing Add const qualifiers to the X509_CRL *x and ASN1_OBJECT *obj arguments of 2018-05-18T14:19:46+00:00 tb 2018-05-18T14:19:46+00:00 urn:sha1:bdec630cd70b31bcfe25cb0be4b325360d75414f X509_CRL_get_ext_count(3), X509_CRL_get_ext_by_NID(3), X509_CRL_get_ext_by_OBJ(3), X509_CRL_get_ext_by_critical(3), X509_CRL_get_ext(3), X509_CRL_get_ext_d2i(3). ok jsing The IMPLEMENT_STACK_OF and IMPLEMENT_ASN1_SET_OF macros were turned into 2015-02-10T08:33:10+00:00 jsing 2015-02-10T08:33:10+00:00 urn:sha1:398669e54cc64c0b7d0a009b29cd2f2ff9063ca9 noops around 15 years ago. Remove multiple occurances of both that still exist in the code today.