openbsd/src/lib/libcrypto/x509/x509_req.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2018-05-13T06:48:00+00:00 Add a const qualifier to the ASN1_OBJECT * argument of the following: 2018-05-13T06:48:00+00:00 tb 2018-05-13T06:48:00+00:00 urn:sha1:acc2166d7c709d3d81530e1bbd78da9c236b7aed EVP_PKEY_get_attr_by_OBJ(3), X509at_get_attr_by_OBJ(3), X509at_get0_data_by_OBJ(3), X509_REQ_get_attr_by_OBJ(3) tested in a bulk by sthen ok beck (as part of a larger diff) Send the function codes from the error functions to the bit bucket, 2017-01-29T17:49:23+00:00 beck 2017-01-29T17:49:23+00:00 urn:sha1:d1f47bd292f36094480caa49ada36b99a69c59b0 as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@ Expand ASN1_ITEM_rptr macros - no change in generated assembly. 2016-12-30T15:24:51+00:00 jsing 2016-12-30T15:24:51+00:00 urn:sha1:3d32963b322889e88515bd7a094bff2bf45065d6 Replace M_ASN1_INTEGER_(new|free) with ASN1_INTEGER_(new|free) - this is 2015-09-30T17:30:16+00:00 jsing 2015-09-30T17:30:16+00:00 urn:sha1:56c28c591a2d58b6dda7237a4962fc6f6b0eca75 different from the macro expansion, but the result is the same. Also replace some ASN1_STRING_dup() with ASN1_INTEGER_dup(). ok beck@ doug@ Avoid a NULL pointer deref when X509_get_pubkey() returns NULL. 2015-03-15T22:52:17+00:00 doug 2015-03-15T22:52:17+00:00 urn:sha1:4fb860a66d9312261140bce7cdc5fbdef4e6e43a A NULL pointer could be dereferenced when X509_REQ_set_pubkey() calls X509_PUBKEY_set() with pktmp. OpenSSL says it's the fix for CVE-2015-0288, but there aren't any public details yet to confirm. Either way, we should fix this. Based on OpenSSL commit 28a00bcd8e318da18031b2ac8778c64147cd54f9 and BoringSSL commit 9d102ddbc0f6ed835ed12272a3d8a627d6a8e728. "looks sane" beck@ ok miod@, bcook@ Someone (TM) thought it was smart to save memory by using malloc(1) and 2014-09-28T10:50:33+00:00 miod 2014-09-28T10:50:33+00:00 urn:sha1:1863db1d9486a762fe4bfcd46c7cce5e0971ed13 manual field fiddling to create an ASN1_INTEGER object, instead of using M_ASN1_INTEGER_new() which will allocate sizeof(long) bytes. That person had probably never looked into malloc(3) and never heard of allocation size rounding. Thus, replace the obfuscated code with M_ASN1_INTEGER_new() followed by ASN1_INTEGER_set(), to achieve a similar result, without the need for /* version == 0 */ comments. ok bcook@ Only import cryptlib.h in the four source files that actually need it. 2014-07-11T08:44:49+00:00 jsing 2014-07-11T08:44:49+00:00 urn:sha1:74e2c009c83ad374bd6acdcfc376a384e25ab007 Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@ Explicitly include <openssl/opensslconf.h> in every file that references 2014-07-10T22:45:58+00:00 jsing 2014-07-10T22:45:58+00:00 urn:sha1:62348213609ef233110561d1a6ed67ad66df1c7e an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers. tags as requested by miod and tedu 2014-06-12T15:49:31+00:00 deraadt 2014-06-12T15:49:31+00:00 urn:sha1:59f4f2c61d71e266d37dd2fc97615b3fd35b4721 malloc() result does not need a cast. 2014-06-07T14:41:57+00:00 deraadt 2014-06-07T14:41:57+00:00 urn:sha1:800fbde652d67326eeb163d56d8f72ebb239b3c4 ok miod