openbsd/src/lib/libcrypto/x509/x509_set.c, branch OPENBSD_7_9_BASE

Drop superfluous parentheses in X509_set_version()

2024-03-26T23:21:36+00:00

piuid and psuid have annoyed me for long enough

2024-03-26T22:44:57+00:00

Reject setting invalid versions for certs, CRLs and CSRs

2024-03-26T11:09:37+00:00

The toolkit aspect bites again. Lots of invalid CRLs and CSRs are produced because people neither read the RFCs nor does the toolkit check anything it is fed. Reviewers apparently also aren't capable of remembering that they have three copy-pasted versions of the same API and that adding a version check to one of the might suggest adding one for the other two. This requires ruby-openssl 20240326p0 to pass ok beck job jsing

Remove some redundant parentheses

2023-06-23T08:00:28+00:00

This file is already enough of an eyesore without them.

Invalidate the DER cache earlier on in X509 setter functions

2023-04-25T10:18:39+00:00

Note that it is important to invalidate the cache before returning, as the return might bubble up an error. OK tb@ jsing@

Introduce X509_get0_uids() accessor function

2023-02-23T18:12:32+00:00

By introducing X509_get0_uids(), one can add RPKI profile compliance checks to conform the absence of the issuerUID and subjectUID. OK tb@ jsing@

libressl _namespace.h: adjust _ALIAS() to require a semicolon

2023-02-16T08:38:17+00:00

LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Hide public symbols in libcrypto/x509 .c files

2022-11-14T17:48:50+00:00

ok tb@

Move the now internal X.509-related structs into x509_lcl.h.

2021-11-01T20:53:08+00:00

Garbage collect the now unused LIBRESSL_CRYPTO_INTERNAL and LIBRESSL_OPAQUE_X509. Include "x509_lcl.h" where needed and fix a couple of unnecessary reacharounds. ok jsing