openbsd/src/lib/libcrypto/x509, branch OPENBSD_6_4_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_4_BASE 2018-08-24T20:26:03+00:00 Add const to EVP_PKCS82PKEY(). 2018-08-24T20:26:03+00:00 tb 2018-08-24T20:26:03+00:00 urn:sha1:2e9cc12db341d66727099e500ca968482802fde1 tested in a bulk by sthen ok jsing After removing support for broken PKCS#8 formats (it was high time), 2018-08-24T20:17:33+00:00 tb 2018-08-24T20:17:33+00:00 urn:sha1:4cdbdc5207fa48804d8ed3a7929a97ae5f9f466d we can add const to PKCS8_pkey_get0(). In order for this to work, we need to sprinkle a few consts here and there. tested in a bulk by sthen ok jsing Remove EVP_PKEY2PKCS8_broken() and PKCS8_set_broken() 2018-08-24T20:07:42+00:00 tb 2018-08-24T20:07:42+00:00 urn:sha1:e4cf8ac5385c963bee0eb8d0e642abe1bb82ac78 Provide PKCS8_pkey_add1_attr_by_NID() and PKCS8_pkey_get0_attrs(). Remove the whole broken code and simplify pkcs8_priv_key_info_st accordingly. Based on OpenSSL commit 54dbf42398e23349b59f258a3dd60387bbc5ba13 plus some const that was added later. tested in a bulk build by sthen ok jsing Provide X509_get0_serialNumber() 2018-08-24T19:59:32+00:00 tb 2018-08-24T19:59:32+00:00 urn:sha1:b2896b6759d33e259f8f56f743ec2d54f5002a50 tested in a bulk by sthen ok jsing Turn a number of #defines into proper functions with prototypes matching 2018-08-24T19:55:58+00:00 tb 2018-08-24T19:55:58+00:00 urn:sha1:d005d0528a66f69dbf8fb1a50b86c1bf40e135bc those that OpenSSL has had for ages. ok jsing Make X509_OBJECT_up_ref_count return an int. 2018-08-24T19:21:09+00:00 tb 2018-08-24T19:21:09+00:00 urn:sha1:74eedf34845483dbab4527b97ece0c1697ff88ff Based on OpenSSL commit c5ebfcab713a82a1d46a51c8c2668c419425b387 tested in a bulk by sthen ok jsing Don't leak sktmp in X509_verify_cert(). 2018-08-19T20:19:31+00:00 tb 2018-08-19T20:19:31+00:00 urn:sha1:72e746eda16b1fcb8e54b3a9bd99c0fa48f51c22 CID #118791 ok jsing mestre Remove unnecessary NULL check from get_cert_by_subject since 2018-08-05T14:17:12+00:00 bcook 2018-08-05T14:17:12+00:00 urn:sha1:6b472be450b41d2399d1fd32bf31177c8c24f895 sk_BY_DIR_HASH_find already does it, removing ambiguity later in the function. ok tb@ Add const to both arguments of X509_certificate_type() and clean up 2018-05-30T15:59:33+00:00 tb 2018-05-30T15:59:33+00:00 urn:sha1:60382f7d19bb7b7087eb92001a800a712bcc4f4a a little: Use X509_get0_pubkey() in place of X509_get_pubkey() and EVP_PKEY_free(). Check return value of the former in the appropriate place and simplify the logic for dealing with the potentially NULL pkey argument (includes a neat tweak from jsing). Finally, kill an ugly comment that has been rotting for twenty years and merge the lines around it. tested in a bulk build by sthen ok jsing Add a const qualifier to the `name' argument of 2018-05-30T15:35:45+00:00 tb 2018-05-30T15:35:45+00:00 urn:sha1:3a37ecacf160203b3975659c0fafbdeb5622c17f X509_NAME_get_index_by_{OBJ,NID}(). tested in a bulk build by sthen suggested by & ok jsing