A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_2 2023-02-07T15:59:13+00:00 2023-02-07T15:59:13+00:00 bluhm 2023-02-07T15:59:13+00:00 urn:sha1:15882269f22f488b8e18605493bb7c0608ab350e The ASN.1 template for GENERAL_NAME and its corresponding C structure disagree on the type of the x400Address member. This results in an ASN.1 string to be considered as an ASN.1 type, which allows an attacker to read (essentially) arbitrary memory. Fix this by forcing comparison as strings. While the underlying type confusion has been present since time immemorial, this particular bug came with the EdiPartyName fix (6.8/008_asn1.patch.sig). Reported by David Benjamin, fix suggested by jsing. Release date for this was set to be January 31. Unilaterally pushed back to February 7 by OpenSSL by way of announcement of many completely unrelated embargoed issues, some of which they had been sitting on since July 2020. from tb@; OK beck@ jsing@ this is errata/7.2/018_x509.patch.sig 2022-10-20T09:45:18+00:00 tb 2022-10-20T09:45:18+00:00 urn:sha1:2e08bcb01b2d496908faf5968f289cda7e088285 In the case that a verification callback is installed that tells the verifier to continue when a certificate is invalid (e.g. expired), any error resulting from the leaf certificate verification is not stored and made available post verification, resulting in an incorrect error being returned. Also perform leaf certificate verification prior to adding the chain, which avoids a potential memory leak (as noted by tb@). Issue reported by Ilya Shipitsin, who encountered haproxy regress failures. ok tb@; from jsing This is errata/7.2/001_x509.patch.sig 2022-09-03T17:47:47+00:00 jsing 2022-09-03T17:47:47+00:00 urn:sha1:f1083ba41574ef4e529cc2ea4ff2aa685c4833cd OPENSSL_cleanup() cleans up and deallocates memory in use by the library. There are a couple of use cases for this, primarily related to memory leak testing. This will not be called automatically in LibreSSL, which means that OpenSSL's OPENSSL_NO_INIT_ATEXIT is implied. If code wants to clean up then they need to explicitly call this themselves. ok tb@ 2022-08-31T07:15:31+00:00 tb 2022-08-31T07:15:31+00:00 urn:sha1:d232bd6af93b87abffb31bf680b072890c17f61d sk_num() can return a negative value, in which case the upper bound is SIZE_MAX, which results in a very long for loop. CID 153997 ok jsing 2022-08-18T16:26:33+00:00 tb 2022-08-18T16:26:33+00:00 urn:sha1:8be3e003ec0a654c1538dbd8f7e6d9d965b2e7dc While each attribute must contain at least one extension, it is not required that a CSR have attributes at all. Instead of signalling an error by returning NULL if no extensions are found, return an empty stack of extensions. Via OpenSSL 1f02ca2d ok jsing 2022-08-15T11:52:37+00:00 tb 2022-08-15T11:52:37+00:00 urn:sha1:726478d55d7f47f50feb22b91bfcb268950310ac 2022-08-05T14:46:52+00:00 beck 2022-08-05T14:46:52+00:00 urn:sha1:33f7a389689c3cc4d7351bfe5ea8496ca7927169 p5-IO-Socket-SSL regress and regress/sbin/iked/live Still passes the mutt regress that this was intended to fix. ok tb@ 2022-07-30T17:50:17+00:00 tb 2022-07-30T17:50:17+00:00 urn:sha1:7004c9ad3ae411f3be9a9af2eb33a5cb6c0fc7d7 ok jsing 2022-07-24T21:41:29+00:00 tb 2022-07-24T21:41:29+00:00 urn:sha1:eedf40d421c29b605c6fd42b96245296f46aafc4 Do not leak the extension that was deleted from the stack. via OpenSSL c3efe5c9. ok jsing 2022-07-12T14:42:50+00:00 kn 2022-07-12T14:42:50+00:00 urn:sha1:89e42d5857196a8071fbafb5565388d0e20ec32b This script is not used at all and files are edited by hand instead. Thus remove misleading comments incl. the obsolete script/config. Feedback OK jsing tb