openbsd/src/lib/libcrypto/x509v3, branch OPENBSD_6_7 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_7 2020-12-08T15:10:03+00:00 Fix a NULL dereference in GENERAL_NAME_cmp() 2020-12-08T15:10:03+00:00 tb 2020-12-08T15:10:03+00:00 urn:sha1:374b8d6eac4ffe208e18d32cd2e1cccc7da35e13 Comparing two GENERAL_NAME structures containing an EDIPARTYNAME can lead to a crash. This enables a denial of service attack for an attacker who can control both sides of the comparison. Issue reported to OpenSSL on Nov 9 by David Benjamin. OpenSSL shared the information with us on Dec 1st. Fix from Matt Caswell (OpenSSL) with a few small tweaks. ok jsing this is errata/6.7/031_asn1.patch.sig initialize safestack pointers 2019-05-08T21:53:10+00:00 bcook 2019-05-08T21:53:10+00:00 urn:sha1:8eb3e6ba91afeb09f96f9f79c8d49b027678c1e3 ok beck@, tb@ Add error checking to i2v_POLICY_MAPPINGS(). 2019-04-22T17:32:09+00:00 tb 2019-04-22T17:32:09+00:00 urn:sha1:0573e2b6aa9d1cb8bec6398735fa0453b0eff91d ok jsing Add error checking to i2v_POLICY_CONSTRAINTS(). 2019-04-22T17:29:13+00:00 tb 2019-04-22T17:29:13+00:00 urn:sha1:84afeb4897145b7414982ec73c6394ddd9f99b19 ok jsing Add error checking to i2v_EXTENDED_KEY_USAGE(). 2019-04-22T17:26:34+00:00 tb 2019-04-22T17:26:34+00:00 urn:sha1:3c4ff2e2dc8678ae063461de4026f7a0c6a46325 ok jsing Add error checking to i2v_ASN1_BIT_STRING(). 2019-04-22T17:23:55+00:00 tb 2019-04-22T17:23:55+00:00 urn:sha1:824eaad7dfe50d2858bd641b0211fe81bd2230c0 ok jsing Add error checking to i2v_BASIC_CONSTRAINTS(). 2019-04-22T17:21:01+00:00 tb 2019-04-22T17:21:01+00:00 urn:sha1:c50b00d5889a23f7e451876dbab1edf03c717840 ok jsing Add error checking to i2v_AUTHORITY_INFO_ACCESS(). While there, replace 2019-04-22T17:18:30+00:00 tb 2019-04-22T17:18:30+00:00 urn:sha1:c993b879b0e630b1091e856ece99cc53fe8fbdf6 an ugly strlen + malloc + strcat/strcpy dance by a simple asprintf(). ok jsing Avoid potential double frees in i2v_AUTHORITY_KEYID(), i2v_GENERAL_NAME() 2019-04-22T17:10:01+00:00 tb 2019-04-22T17:10:01+00:00 urn:sha1:2797555b85e85f691fa70de4823ab91a801c3059 and i2v_GENERAL_NAMES() by taking ownership of the extlist only if we were passed NULL. Otherwise it remains the caller's responsibility to free it. To do so, we allocate the extlist explicitly instead of using X509V3_add_value()'s implicit allocation feature. Preserve behavior in i2v_AUTHORITY_KEYID() by adding an explicit check that something was pushed onto the stack. The other i2v_* functions will receive a similar treatment in upcoming commits. ok jsing Add error checking to i2v_AUTHORITY_KEYID(), i2v_GENERAL_NAME() 2019-04-21T16:50:34+00:00 tb 2019-04-21T16:50:34+00:00 urn:sha1:a01da1106e8ac7c9458b57ed7467f79a0e445134 and i2v_GENERAL_NAMES(). This fixes a couple of leaks and other ugliness. tweaks & ok jsing