openbsd/src/lib/libcrypto/x509v3, branch libressl-v2.9.2

Fix a number of ASN1_INTEGER vs ASN1_STRING mixups coming from the

2019-03-13T20:34:00+00:00

mechanical M_ASN1 macro expansion. The ASN1_INTEGER_cmp function takes signs into account while ASN1_STRING_cmp doesn't. The mixups mostly involve serialNumbers, which, in principle, should be positive. However, it is unclear whether that is checked or enforced anywhere in the code, so these are probably bugs. Patch from Holger Mikolon ok jsing

Add a const qualifier to the aint argument of X509V3_add_value_int()

2018-05-19T10:50:08+00:00

Tested in a bulk build by sthen ok jsing

Add a const qualifier to the STACK_OF(X509_EXTENSION) * arguments of

2018-05-19T10:41:53+00:00

X509V3_get_d2i() and X509V3_extensions_print(), and one to the 'title' argument of the latter function. tested in a bulk build by sthen ok jsing

Add a const qualifier to the 'key' argument of i2o_ECPublicKey() and

2018-05-19T10:37:02+00:00

one to the last argument of each one of i2s_ASN1_OCTET_STRING(), s2i_ASN1_OCTET_STRING(), i2s_ASN1_INTEGER(), i2s_ASN1_ENUMERATED(), and i2s_ASN1_ENUMERATED_TABLE(). tested in a bulk build by sthen ok jsing

The 'name', 'value' and 'section' arguments for a2i_GENERAL_NAME(),

2018-05-18T19:34:37+00:00

X509V3_get_value_bool(), X509V3_add_value_bool_nf(), X509V3_get_value_int(), X509V3_get_string(), X509V3_get_section() are now const. While there, remove a stupid cast and two redundant checks. tested in a bulk build by sthen ok jsing

Add const qualifiers to the 'name', 'sname' and 'X509_PURPOSE *'

2018-05-18T18:30:03+00:00

arguments of X509_PURPOSE_add(3), X509_PURPOSE_get0_name(3), X509_PURPOSE_get0_sname(3), X509_PURPOSE_get_by_sname(3), X509_PURPOSE_get_id(3), X509_PURPOSE_get_trust(3). tested in a bulk build by sthen ok jsing

Add const to the 'name', 'value', and 'section' arguments of

2018-05-13T17:49:03+00:00

X509V3_EXT_{,n}conf_nid(3), X509_EXT_{,n}conf(3) X509V3{,_CRL,_REQ}_add_{,n}conf(3) as well as the get_string() and get_section() members of X509_CONF_METHOD_st. tested in a bulk build by sthen ok jsing

Add const qualifiers to the char zone and char user arguments of

2018-05-13T15:03:01+00:00

SXNET_add_id_INTEGER(3), SXNET_add_id_asc(3), SXNET_add_id_ulong(3) tested in a bulk by sthen ok jsing

Add const to functions in asn1/asn1.h as they did in OpenSSL.

2018-04-25T11:48:21+00:00

BIO_f_asn1() will be taken care of later. Tested in a bulk by sthen ok bcook jca jsing

If X509_check_{host,email}() are called with a length of zero, use strlen()

2018-03-20T16:16:59+00:00

to determine the length. This is the documented behaviour and matches the OpenSSL implementation. Issue found by Michael Gmelin . ok tb@