openbsd/src/lib/libcrypto, branch libressl-v2.5.1

LibreSSL : Truncated packet could crash via OOB read

2017-01-31T13:17:21+00:00

This patch is originally from master branch of OpenSSL. - 2198b3a crypto/evp: harden AEAD ciphers. - 8e20499 crypto/evp: harden RC4_MD5 cipher. ok tom@

Document functions returning standard moduli for DH key exchange.

2017-01-31T05:40:26+00:00

jsing@ confirmed that these are public and worth documenting.

tweak previous;

2017-01-30T07:51:27+00:00

Document BN_set_flags(3) and BN_get_flags(3).

2017-01-30T01:29:31+00:00

jsing@ confirmed that these macros are public and worth documenting.

Seriously warn against calling BN_init(3), BN_MONT_CTX_init(3),

2017-01-29T23:41:49+00:00

and BN_RECP_CTX_init(3). They are not only deprecated but so dangerous that they are almost unusable. I found these scary traps while reading the code in order to document BN_set_flags(3). While here, delete ERR_get_error(3) from SEE ALSO.

Send the function codes from the error functions to the bit bucket,

2017-01-29T17:49:23+00:00

as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@

Hide SSLerr() under #ifndef LIBRESSL_INTERNAL since we shouldn't be

2017-01-26T12:07:06+00:00

using it anymore ok jsing@

Document ERR_load_BN_strings(3).

2017-01-26T04:37:08+00:00

jsing@ confirmed that this function is public and worth documenting. This page needs much more work, it is outrageously incomplete and unclear. For example, it remains unexplained what error strings are, what "registering" means and what the benefit for the application is, what happens if it is not done, or what happens if an error occurs after calling ERR_free_strings(3). I tried to read the code, but it is so contorted that i postponed that work. For example, it looks like there are hooks for applications to replace the functions used for registering strings by other, application-supplied functions, and, of course, there are many levels of macro and function wrappers. For now, i only documented the most obvious BUGS.

document BN_asc2bn(3);

2017-01-25T16:12:45+00:00

jsing@ confirmed that it is a public function worth documenting

Construct a BN_gcd_nonct, based on BN_mod_inverse_no_branch, as suggested

2017-01-25T06:15:44+00:00

by Alejandro Cabrera to avoid the possibility of a sidechannel timing attack during RSA private key generation. Modify BN_gcd to become not visible under LIBRESSL_INTERNAL and force the use of the _ct or _nonct versions of the function only within the library. ok jsing@