openbsd/src/lib/libcrypto, branch libressl-v3.2.1 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.2.1 2020-08-06T22:17:49+00:00 delete another word to improve the wording; suggested by jmc@ 2020-08-06T22:17:49+00:00 schwarze 2020-08-06T22:17:49+00:00 urn:sha1:ad80f89c979f67100839da48dfd0910c6039ad62 Explain the purpose of CMAC_resume(3) in more detail. 2020-08-06T15:40:29+00:00 schwarze 2020-08-06T15:40:29+00:00 urn:sha1:0d60cc36d75fe570b014800800b275a6b603296d Triggered by jmc@ apparently misunderstanding the intention of the text and fixing a grammatical error in a way that wasn't ideal, so i guess he wouldn't have been the only one to find the previous version hard to understand. OK jmc@ remove half a dozen "goto" statements and a label 2020-07-25T11:53:37+00:00 schwarze 2020-07-25T11:53:37+00:00 urn:sha1:0030d031a0ace03c9c7be82b8c636ad0dfbda45d that change nothing whatsoever, except making the code harder to read; OK tb@ tweak previous; 2020-07-24T16:38:47+00:00 jmc 2020-07-24T16:38:47+00:00 urn:sha1:0be571f1674aea144e7d6e764d8b001b0993aca4 document PEM_X509_INFO_read(3) and PEM_X509_INFO_read_bio(3) 2020-07-23T17:34:53+00:00 schwarze 2020-07-23T17:34:53+00:00 urn:sha1:d819d77700bfdd43e362a615c47213b1635b35e6 OK tb@ Fix a bug in PEM_X509_INFO_read_bio(3) that is very likely to cause 2020-07-23T17:15:35+00:00 schwarze 2020-07-23T17:15:35+00:00 urn:sha1:bc9c51cf66fc92815074622c1c64a0e8bd9d5796 use-after-free and double-free issues in calling programs. The bug was introduced in SSLeay-0.6.0 released on June 21, 1996 and has been present since OpenBSD 2.4. I found the bug while documenting the function. The bug could bite in two ways that looked quite different from the perspective of the calling code: * If a stack was passed in that already contained some X509_INFO objects and an error occurred, all the objects passed in would be freed, but without removing the freed pointers from the stack, so the calling code would probable continue to access the freed pointers and eventually free them a second time. * If the input BIO contained at least two valid PEM objects followed by at least one PEM object causing an error, at least one freed pointer would be put onto the stack, even though the function would return NULL rather than the stack. But the calling code would still have a pointer to the stack, so it would be likely to access the new bogus pointers sooner or later. Fix all this by remembering the size of the input stack on entry and cutting it back to exactly that size when exiting due to an error, but no further. While here, do some related cleanup: * Garbage collect the automatic variables "error" and "i" which were only used at one single place each. * Use NULL rather than 0 for pointers. I like bugfixes that make the code four lines shorter, reduce the number of variables by one, reduce the number of brace-blocks by one, reduce the number if if-statements by one, and reduce the number of else-clauses by one. Tweaks and OK tb@. Disable assembly code for powerpc64; more work is needed to make it work. 2020-06-29T15:32:44+00:00 kettenis 2020-06-29T15:32:44+00:00 urn:sha1:310bee1edf5b91769a0ac118970281584681c964 Switch back to bn_mul_mont_int since the bn_mul_mont_fpu64 code isn't 2020-06-28T07:50:57+00:00 kettenis 2020-06-28T07:50:57+00:00 urn:sha1:a80c6039db0a80be13429a253b36af2a9a640d28 hooked up and the lack of a bn_mul_mont_int implementation results in undefined references. Accidentally doubled these files on first commit. Correcting. 2020-06-26T00:39:59+00:00 drahn 2020-06-26T00:39:59+00:00 urn:sha1:7fa21907fd3ec1e649ebd8ca6ee174ba7be784af Intial attempt at powerpc64 libcrypto pieces. 2020-06-25T04:29:08+00:00 drahn 2020-06-25T04:29:08+00:00 urn:sha1:514ce84a72439fc2ef9cc67602c0d2ebfc6da73d just commit this kettenis@