A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.2.6 2021-08-20T19:54:16+00:00 2021-08-20T19:54:16+00:00 benno 2021-08-20T19:54:16+00:00 urn:sha1:a0edaa1df7ef2c86291fda512c1ac0b4bee8b545 X509_CERT_AUX_print(). Commit in -current: CVSROOT: /cvs Module name: src Changes by: schwarze@cvs.openbsd.org 2021/07/10 11:45:16 Modified files: lib/libcrypto/asn1: t_x509a.c Log message: Fix a read buffer overrun in X509_CERT_AUX_print(3), which by implication also affects X509_print(3). The ASN1_STRING_get0_data(3) manual explitely cautions the reader that the data is not necessarily NUL-terminated, and the function X509_alias_set1(3) does not sanitize the data passed into it in any way either, so we must assume the alias->data field is merely a byte array and not necessarily a string in the sense of the C language. I found this bug while writing manual pages for these functions. OK tb@ As an aside, note that the function still produces incomplete and misleading results when the data contains a NUL byte in the middle and that error handling is consistently absent throughout, even though the function provides an "int" return value obviously intended to be 1 for success and 0 for failure, and even though this function is called by another function that also wants to return 1 for success and 0 for failure and even does so in many of its code paths, though not in others. But let's stay focussed. Many things would be nice to have in the wide wild world, but a buffer overflow must not be allowed to remain in our backyard. This is patches/6.8/common/029_x509.patch.sig 2021-02-03T07:06:14+00:00 tb 2021-02-03T07:06:14+00:00 urn:sha1:5eca2774fbb65f0eac0df1f87aaa91c139b0f724 Various interoperability issues and memory leaks were discovered in libcrypto and libssl. The new verifier is not bug compatible with the old verifier and caused many issues by failing to propagate errors correctly, returning different error codes than some software was trained to expect and otherwise failing when it shouldn't. While much of this is fixed in -current, it's still not perfect, so switching back to the legacy verifier is preferable at this point. Other included fixes: * Unbreak DTLS retransmissions for flights that include a CCS * Only check BIO_should_read() on read and BIO_should_write() on write * Implement autochain for the TLSv1.3 server * Use the legacy verifier for AUTO_CHAIN * Implement exporter for TLSv1.3 * Free alert_data and phh_data in tls13_record_layer_free() * Plug leak in x509_verify_chain_dup() * Free the policy tree in x509_vfy_check_policy() Original commits by jsing and tb ok inoguchi jsing 2020-12-08T15:08:47+00:00 tb 2020-12-08T15:08:47+00:00 urn:sha1:267ac14fa6781b6553b05a6d8dcdf99eaacc0edf Comparing two GENERAL_NAME structures containing an EDIPARTYNAME can lead to a crash. This enables a denial of service attack for an attacker who can control both sides of the comparison. Issue reported to OpenSSL on Nov 9 by David Benjamin. OpenSSL shared the information with us on Dec 1st. Fix from Matt Caswell (OpenSSL) with a few small tweaks. ok jsing this is errata/6.8/008_asn1.patch.sig 2020-09-26T15:44:06+00:00 jsing 2020-09-26T15:44:06+00:00 urn:sha1:4e8347390553060ef9ddb7e486d3c945d2af54ab Previously the leaf certificate was only being set up on the X509_STORE_CTX after two verification steps were performed, however at least one of those steps could result in the verification callback being triggered and existing code breaking. Issue noticed by Raf Czlonka when attempting to connect to talk.google.com using profanity (which does not set SNI and ends up receiving an invalid certificate). ok beck@ deraadt@ tb@ 2020-09-26T02:06:28+00:00 deraadt 2020-09-26T02:06:28+00:00 urn:sha1:3e6655fb0b20e8ae2d4546bab15df8fe320eec75 2020-09-25T11:31:39+00:00 bcook 2020-09-25T11:31:39+00:00 urn:sha1:33b8c9d48b4113d7a8f7d647bbf752c75a0a83e3 ok tb@ 2020-09-25T11:25:31+00:00 tb 2020-09-25T11:25:31+00:00 urn:sha1:595cb14b635063eb152a7a571795b041671c0869 2020-09-25T11:17:52+00:00 tb 2020-09-25T11:17:52+00:00 urn:sha1:1efcbc50096abcd1a19ce4d45d4d127e06e04413 2020-09-25T11:05:21+00:00 tb 2020-09-25T11:05:21+00:00 urn:sha1:66d1ad87ddaa338c343987d00bcc03cf1d438b4a Use calloc() instead of malloc() and setting all members manually to 0. Avoid unnecessary else branch. 2020-09-25T10:56:36+00:00 tb 2020-09-25T10:56:36+00:00 urn:sha1:1b9a5c6ef789bd22c50707defa5b78bfdc8d6fec a pointless local scope. suggested by jsing