openbsd/src/lib/libcrypto, branch tb_20230422A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=tb_202304222023-04-23T13:43:47+00:00This commit was manufactured by cvs2git to create tag 'tb_20230422'.2023-04-23T13:43:47+00:00cvs2svnadmin@example.com2023-04-23T13:43:47+00:00urn:sha1:e2496982472bdf233be95c5ea72d1c4dc6c91db3Drop some extra parentheses2023-04-23T11:52:14+00:00tb2023-04-23T11:52:14+00:00urn:sha1:3999ba491ccd1196e93f475303269b93430209faDrop a superfluous isneg check.2023-04-23T11:39:56+00:00tb2023-04-23T11:39:56+00:00urn:sha1:a144bab8654472b756f3b2973465b9c89b2f56a2Add missing NULL check for BN_new()2023-04-23T11:34:57+00:00tb2023-04-23T11:34:57+00:00urn:sha1:ff36f25f7ccd3f6edb9f06c26f12c96a19847c09Initialize ishex and isneg at the top and drop some elses2023-04-23T11:25:21+00:00tb2023-04-23T11:25:21+00:00urn:sha1:0d736aa8eb426f9e1fb0c6e8fa09cb32effd7f7fAlign hex_to_string with OpenSSL 1.1 behavior2023-04-23T10:19:52+00:00tb2023-04-23T10:19:52+00:00urn:sha1:a77795d252b58fa4bbaf3beec1fa1dac50f6785c
This is a bit of a strange one. When this function was moved and renamed,
somehow checks for NULL pointers and 0 length were lost. Whether that was
due to great review missing it or great review suggesting it, is unclear.
Now the function can actually legitimately be called with a length of 0
(as ASN.1 OCTET STRINGS can have length 0) and "" is the appropriate
representation for that, so the fix is to allocate a 0 octet. That much
was correct. What was completely missed is that a long can be negative
which will then still lead to an out-of-bounds access. So fix that as
well.
Finally, don't malloc 3 * len + 1 without overflow checking. Rather
use calloc's internal checks. The + 1 isn't really needed anyway.
All this is still really gross and can be done much more cleanly and
safely with CBB/CBS. This will done later once we have better regress
coverage.
ok jsing
x509_utl.c: Use correct spelling of NULL2023-04-23T09:58:38+00:00tb2023-04-23T09:58:38+00:00urn:sha1:096877f0408128467e9955e510bce04c2d583bf4Improve bn_montgomery_multiply_words()2023-04-22T14:31:44+00:00jsing2023-04-22T14:31:44+00:00urn:sha1:d95935343b3c1b937475cb005227b89d04313ff9
Pull a number of invariants into variables, which avoids repeated loading
from memory on architectures where sufficient registers are available.
Also keep track of the per-iteration carry in a variable, rather than
unnecessarily reading from and writing to memory.
This gives a reasonable performance gain on some architectures (e.g. armv7)
cms_io: sort includes2023-04-21T20:36:07+00:00tb2023-04-21T20:36:07+00:00urn:sha1:7d3ef330ac517c8cc233b8a03274e590429b7e7bcms_io: reverse polarity of an if statement to unindent2023-04-21T20:33:37+00:00tb2023-04-21T20:33:37+00:00urn:sha1:c8ee5ae9adae1101485ddaa4a86eac0ec8e8970a