openbsd/src/lib/libssl/bs_cbs.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2019-01-23T22:20:40+00:00 assert.h is often misused. It should not be used in a library 2019-01-23T22:20:40+00:00 beck 2019-01-23T22:20:40+00:00 urn:sha1:5f0a8a144321350e4fbf1de6dd8937ff85055a6d ok bcook@ jsing@ Stop using BUF_memdup() within the LibreSSL code base - it is correctly 2015-06-24T09:44:18+00:00 jsing 2015-06-24T09:44:18+00:00 urn:sha1:346042b6e220ac94d87729e430272193855ae67a spelt malloc+memcpy, which is what is used in all except two places. ok deraadt@ doug@ Change CBS_dup() to also sync the offset. 2015-06-23T05:58:28+00:00 doug 2015-06-23T05:58:28+00:00 urn:sha1:9a31903e554f01ace552d6ed0a48e3af5e464664 Previously, CBS_dup() had its own offset. However, it is more consistent to copy everything. ok miod@ jsing@ Replace internal call to CRYPTO_memcmp with timingsafe_memcmp. 2015-06-20T01:21:51+00:00 doug 2015-06-20T01:21:51+00:00 urn:sha1:8f9592772f7e719ef92d7e0ccc1c46212180591a Suggested by jsing@. ok jsing@ miod@ Add CBS_dup() to initialize a new CBS with the same values. 2015-06-19T00:23:36+00:00 doug 2015-06-19T00:23:36+00:00 urn:sha1:512915f28ea9c781f7fb047c687e3863fa3168b7 This is useful for when you need to check the data ahead and then continue on from the same spot. input + ok jsing@ miod@ Use explicit int in bs_cbs.c. 2015-06-17T07:25:56+00:00 doug 2015-06-17T07:25:56+00:00 urn:sha1:57e742a1d579791e1b790335874f838b2ccc286a ok miod@ jsing@ Add CBS_write_bytes() to copy the remaining CBS bytes to the caller. 2015-06-17T07:06:22+00:00 doug 2015-06-17T07:06:22+00:00 urn:sha1:a0e2b99538b9b1895c2d8eee148f86142f9e99f7 This is a common operation when dealing with CBS. ok miod@ jsing@ Add a new function CBS_offset() to report the current offset in the data. 2015-06-17T07:00:22+00:00 doug 2015-06-17T07:00:22+00:00 urn:sha1:3f41fbd5a47c722047de0a060c1e410a5fba87bb "why not" miod@, sure jsing@ Simplify cbs_get_any_asn1_element_internal based on comments from jsing@ 2015-06-16T06:11:39+00:00 doug 2015-06-16T06:11:39+00:00 urn:sha1:9df3ee5634f566b673844ce7c87d9cd5481d92c7 Make CBS_get_any_asn1_element() more compliant with DER encoding. 2015-06-15T07:35:49+00:00 doug 2015-06-15T07:35:49+00:00 urn:sha1:f06caa67ef95efe3935b9b1e51f4e8a10a52d973 CBS_get_any_asn1_element violates DER encoding by allowing indefinite form. All callers except bs_ber.c expect DER encoding. The callers must check to see if it was indefinite or not. Rather than exposing all callers to this behavior, cbs_get_any_asn1_element_internal() allows specifying whether you want to allow the normally forbidden indefinite form. This is used by CBS_get_any_asn1_element() for strict DER encoding and by a new static function in bs_ber.c for the relaxed version. While I was here, I added comments to differentiate between ASN.1 restrictions and CBS limitations. ok miod@