A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2020-09-26T14:43:17+00:00 2020-09-26T14:43:17+00:00 jsing 2020-09-26T14:43:17+00:00 urn:sha1:b147e2d737372e25e4ae27eb3f3cf46c472e9055 Currently dtls1_drain_fragments() has a incomplete handrolled version of dtls1_hm_fragment_free(), which has the potential to leak memory. Replace the handrolled free with a call to dtls1_hm_fragment_free(). ok inoguchi@ tb@ 2020-09-26T08:58:00+00:00 jsing 2020-09-26T08:58:00+00:00 urn:sha1:f4c0739084aedd02b6fe70b1b3fd77fb833e59c1 Rather than using local variables and having to remember which things need to be freed upon a failure at a certain point, simply allocate into the hm_fragment struct and call dtls1_hm_fragment_free() on failure. Also use calloc() to ensure memory is appropriately zeroed/initialised. ok tb@ 2020-08-11T19:13:35+00:00 jsing 2020-08-11T19:13:35+00:00 urn:sha1:885110ef90d6077c936a51758ce6aaf4aa445b03 ok inoguchi@ tb@ 2019-02-10T16:42:35+00:00 phessler 2019-02-10T16:42:35+00:00 urn:sha1:32885e3a04801a2e183dbc1efdc792341d99460c instead From Pamela Mosiejczuk, many thanks! OK phessler@ deraadt@ 2018-11-08T22:28:52+00:00 jsing 2018-11-08T22:28:52+00:00 urn:sha1:d1a7f20049bf29c61782397cffb632339b12ba54 This provides a cleaner, simpler and more readable API, with code that uses a BUF_MEM instead of a BIO. ok beck@ ("hurry up") and tb@. 2018-09-05T16:58:59+00:00 jsing 2018-09-05T16:58:59+00:00 urn:sha1:4e47c515f40e5440374f3cb833834c52edfd8b18 EVP_MD_CTX_create -> EVP_MD_CTX_new EVP_MD_CTX_destroy -> EVP_MD_CTX_free This should make the intent more obvious and reduce head scratching during code reviews. Raised by tb@ 2018-08-30T16:56:16+00:00 jsing 2018-08-30T16:56:16+00:00 urn:sha1:16b6459b65a2ea71c62cee66fa098dd1e7b7cd8d ssl3_pending() is used for all protocols and dtls1_shutdown() just calls ssl3_shutdown(), so just call the appropriate function directly instead. ok beck@ inoguchi@ tb@ 2018-08-27T16:56:46+00:00 jsing 2018-08-27T16:56:46+00:00 urn:sha1:255faac6cd54c310c2ae857446c5f81ab173d258 There are three versions of the DTLS header writing code, which primarily differ by the fragment offset and fragment length values that differ. Rework dtls1_write_message_header() such that it can be used in all three cases and convert it to CBB in the process. ok inoguchi@ tb@ 2017-10-08T16:24:02+00:00 jsing 2017-10-08T16:24:02+00:00 urn:sha1:ba9ebd2e46ba795dd4f082910e89df705f1e264b which allows us to drop dtls1_send_change_cipher_spec() entirely. ok inoguchi@ 2017-05-07T04:22:24+00:00 beck 2017-05-07T04:22:24+00:00 urn:sha1:2439ee31e965a96d3685f362e5a32d365a9e5eaa while we are at it, convert SSLerror to use a function internally, so that we may later allocate the handshake structure and check for it ok jsing@