openbsd/src/lib/libssl/d1_both.c, branch OPENBSD_7_9_BASE

Support OPENSSL_NO_FILENAMES

2025-03-09T15:12:18+00:00

Some people are concerned that leaking a user name is a privacy issue. Allow disabling the __FILE__ and __LINE__ argument in the error stack to avoid this. This can be improved a bit in tree. From Viktor Szakats in https://github.com/libressl/portable/issues/761 ok bcook jsing

spelling fixes; from paul tagliamonte

2022-12-26T07:31:44+00:00

ok tb

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Get rid of SSL_CTX_INTERNAL and SSL_INTERNAL.

2022-10-02T16:36:42+00:00

These are no longer necessary due to SSL_CTX and SSL now being fully opaque. Merge SSL_CTX_INTERNAL back into SSL_CTX and SSL_INTERNAL back into SSL. Prompted by tb@

Bye bye S3I.

2022-02-05T14:54:10+00:00

S3I has served us well, however now that libssl is fully opaque it is time to say goodbye. Aside from removing the calloc/free/memset, the rest is mechanical sed. ok inoguchi@ tb@

Fold DTLS1_STATE_INTERNAL into DTLS1_STATE.

2021-10-23T13:36:03+00:00

Now that DTLS1_STATE is opaque, fold DTLS1_STATE_INTERNAL back into DTLS1_STATE and remove D1I() usage. ok tb@

Untangle ssl3_get_message() return values.

2021-10-23T08:34:36+00:00

This function currently has a long return type that may be <= 0 on error/retry (which is then cast to an int in order to return it up the stack), or it returns the length of the handshake message (on success). This obviously means that 0 can be returned for both success and failure, which is the reason why a separate 'ok' argument has to exist. Untangle this mess by changing the return value to an int that indicates success (1) or error/retry (<= 0). The length never needs to actually be returned as it is already stored in s->internal->init_num (which is where the return value is read from anyway). ok tb@

Change dtls1_get_message_header() to take a CBS.

2021-09-04T14:24:28+00:00

The callers know the actual length and can initialise a CBS correctly. ok inoguchi@ tb@

Mop up dtls1_get_ccs_header() and struct ccs_header_st.

2021-07-19T08:42:24+00:00

All this code does is read one byte from memory with an unknown length, potentially being a one byte overread... and then nothing is actually done with the value. ok tb@

Merge SSL_METHOD_INTERNAL into SSL_METHOD.

2021-07-01T17:53:39+00:00

Now that SSL_METHOD is opaque and in internal headers, we can remove SSL_METHOD_INTERNAL by merging it back into SSL_METHOD. ok tb@