openbsd/src/lib/libssl/d1_lib.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2020-09-26T14:43:17+00:00Call dtls1_hm_fragment_free() from dtls1_drain_fragments()2020-09-26T14:43:17+00:00jsing2020-09-26T14:43:17+00:00urn:sha1:b147e2d737372e25e4ae27eb3f3cf46c472e9055
Currently dtls1_drain_fragments() has a incomplete handrolled version of
dtls1_hm_fragment_free(), which has the potential to leak memory. Replace
the handrolled free with a call to dtls1_hm_fragment_free().
ok inoguchi@ tb@
Have dtls1_new() call dtls1_free() on failure.2020-09-26T09:01:05+00:00jsing2020-09-26T09:01:05+00:00urn:sha1:16a00524267404e94d8c26a27dd54a75587920e7
Allocate into the appropriate structures and call dtls1_free() on failure,
rather than allocating into local variables and then remembering to free
various things on failure.
ok tb@
Refactor dtls1_clear_queues()2020-09-26T07:36:51+00:00tb2020-09-26T07:36:51+00:00urn:sha1:4284d3c95b72551c4d0f88087d7ef3e863d48e86
An upcoming cleanup diff by jsing needs dtls1_clear_queues() to be
able to handle NULL pqueues. While one can easily add a NULL check
to pqueue_pop(), this does not really fit in with the rest of the
code. There are two kinds of while loops in dtls1_clear_queues that
drain pqueues, so add two helper functions with a NULL check each.
ok jsing
Release read and write buffers using freezero().2020-09-24T17:59:54+00:00jsing2020-09-24T17:59:54+00:00urn:sha1:1328e78055c6ad087ebbec8484862dea13576ef5
Provide a ssl3_release_buffer() function that correctly frees a buffer
and call it from the appropriate locations. While here also change
ssl3_release_{read,write}_buffer() to void since they cannot fail and
no callers check the return value currently.
ok beck@ inoguchi@ tb@
Remove some unnecessary function pointers from SSL_METHOD_INTERNAL.2020-07-07T19:31:11+00:00jsing2020-07-07T19:31:11+00:00urn:sha1:af06ca6427e355a07e5ee9751f9d0ef96f73e5a7
ssl_version is completely unused and get_timeout is the same everywhere.
ok beck@ inoguchi@ tb@
Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.2020-03-12T17:01:53+00:00jsing2020-03-12T17:01:53+00:00urn:sha1:63b0f131cbf0e20ff888516045c6693e8515333f
SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in
public headers, even though their usage is internal. This moves to
using _INTERNAL suffixed versions that are in internal headers, which
then allows us to change them without any potential public API fallout.
ok inoguchi@ tb@
Remove the enc function pointers.2020-03-10T17:02:21+00:00jsing2020-03-10T17:02:21+00:00urn:sha1:7895b558af2262d6d71a405d98e524b072c4a3d8
The enc function pointers do not serve any purpose these days - remove
a layer of indirection and call dtls1_enc()/tls1_enc() directly.
ok inoguchi@ tb@
Convert dtls1_build_sequence_number() to CBB.2020-02-21T16:12:18+00:00jsing2020-02-21T16:12:18+00:00urn:sha1:04331420fb5aece21e40cda3c431aae91437700c
ok inoguchi@ tb@
Use freezero() for the internal opaque structures, instead of the current2017-04-10T17:27:33+00:00jsing2017-04-10T17:27:33+00:00urn:sha1:19e5fc4a206c3a514871cf1e2660d7211dc69ca8
explicit_bzero()/free(). Less code and potentially less overhead.
Change SSLerror() back to taking two args, with the first one being an SSL *.2017-02-07T02:08:38+00:00beck2017-02-07T02:08:38+00:00urn:sha1:9a5920738bea15430db1fdd138e67d9bbc3a95d3
Make a table of "function codes" which maps the internal state of the SSL *
to something like a useful name so in a typical error in the connection you
know in what sort of place in the handshake things happened. (instead of
by arcane function name).
Add SSLerrorx() for when we don't have an SSL *
ok jsing@ after us both being prodded by bluhm@ to make it not terrible