openbsd/src/lib/libssl/s3_cbc.c, branch OPENBSD_6_8_BASE

We inherited the constant time CBC padding removal from BoringSSL, but

2020-06-19T21:26:40+00:00

missed a subsequent fix for an off-by-one in that code. If the first byte of a CBC padding of length 255 is mangled, we don't detect that. Adam Langley's BoringSSL commit 80842bdb44855dd7f1dde64a3fa9f4e782310fc7 Fixes the failing tlsfuzzer lucky 13 test case. ok beck inoguchi

Consistently spell 'unsigned' as 'unsigned int', as style(9) seems

2020-03-16T15:25:14+00:00

to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing

Stop overloading the record type for padding length.

2020-03-12T17:09:02+00:00

Currently the CBC related code stuffs the padding length in the upper bits of the type field... stop doing that and add a padding_length field to the record struct instead. ok inoguchi@ tb@

Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.

2020-03-12T17:01:53+00:00

SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in public headers, even though their usage is internal. This moves to using _INTERNAL suffixed versions that are in internal headers, which then allows us to change them without any potential public API fallout. ok inoguchi@ tb@

Move l2n/l2n8 into s3_cbc.c, since this is the only code that uses it.

2020-02-21T16:07:00+00:00

ok inoguchi@ tb@

Remove now unused code for EVP_CIPH_FLAG_AEAD_CIPHER and EVP_CIPH_GCM_MODE.

2018-09-08T14:39:41+00:00

ok inoguchi@ tb@

move back read_hash and enc_read_ctx into ssl_st. wpa_supplicant and

2017-01-23T08:08:06+00:00

other perversions touches them sickly and unnaturally.

Move a large part of ssl_st into internal, so we can see what squeals.

2017-01-23T06:45:30+00:00

ok jsing@

When using an union including a type known for having strong alignment

2016-11-08T21:25:01+00:00

constraints, in order to force the union to have the same constraint, use the actual type instead of `double'. And add a comment explaining why we want such an alignment in there. ok beck@

Remove unused SSLv3 from ssl3_cbc_record_digest_supported().

2016-11-06T17:21:04+00:00

From Markus Uhlin ok beck@ bcooK@