openbsd/src/lib/libssl/s3_cbc.c, branch OPENBSD_7_9

Make internal header file names consistent

2022-11-26T16:08:57+00:00

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include was fixed manually. discussed with jsing, no objection bcook

Convert s3_cbc.c to opaque EVP_MD_CTX.

2021-12-09T17:45:49+00:00

ok inoguchi jsing

Make local header inclusion consistent.

2021-05-16T14:10:43+00:00

Consistently include local headers in the same location, using the same grouping/sorting across all files.

Reimplement the TLSv1.2 record handling for the read side.

2020-10-03T17:35:17+00:00

This is the next step in replacing the TLSv1.2 record layer. The existing record handling code does decryption and processing in place, which is not ideal for various reasons, however it is retained for now as other code depends on this behaviour. Additionally, CBC requires special handling to avoid timing oracles - for now the existing timing safe code is largely retained. ok beck@ inoguchi@ tb@

We inherited the constant time CBC padding removal from BoringSSL, but

2020-06-19T21:26:40+00:00

missed a subsequent fix for an off-by-one in that code. If the first byte of a CBC padding of length 255 is mangled, we don't detect that. Adam Langley's BoringSSL commit 80842bdb44855dd7f1dde64a3fa9f4e782310fc7 Fixes the failing tlsfuzzer lucky 13 test case. ok beck inoguchi

Consistently spell 'unsigned' as 'unsigned int', as style(9) seems

2020-03-16T15:25:14+00:00

to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing

Stop overloading the record type for padding length.

2020-03-12T17:09:02+00:00

Currently the CBC related code stuffs the padding length in the upper bits of the type field... stop doing that and add a padding_length field to the record struct instead. ok inoguchi@ tb@

Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.

2020-03-12T17:01:53+00:00

SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in public headers, even though their usage is internal. This moves to using _INTERNAL suffixed versions that are in internal headers, which then allows us to change them without any potential public API fallout. ok inoguchi@ tb@

Move l2n/l2n8 into s3_cbc.c, since this is the only code that uses it.

2020-02-21T16:07:00+00:00

ok inoguchi@ tb@

Remove now unused code for EVP_CIPH_FLAG_AEAD_CIPHER and EVP_CIPH_GCM_MODE.

2018-09-08T14:39:41+00:00

ok inoguchi@ tb@