A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2020-01-21T05:19:02+00:00 2020-01-21T05:19:02+00:00 jsing 2020-01-21T05:19:02+00:00 urn:sha1:b37508927616e0339a6459a12d43ae4a56ef7b3d This allows us to indicate that the cause of the failure is unknown, rather than implying that it was an internal error when it was not. ok beck@ 2018-03-20T15:28:12+00:00 tb 2018-03-20T15:28:12+00:00 urn:sha1:a630606aa9bbdbdb6a403eeae3218ed26367572c ok jsing 2017-08-28T17:36:58+00:00 jsing 2017-08-28T17:36:58+00:00 urn:sha1:d9ef76a783487023b993c59e29c97b1fafa98a80 Based on a diff from doug@, similar diff from inoguchi@ 2017-05-07T04:22:24+00:00 beck 2017-05-07T04:22:24+00:00 urn:sha1:2439ee31e965a96d3685f362e5a32d365a9e5eaa while we are at it, convert SSLerror to use a function internally, so that we may later allocate the handshake structure and check for it ok jsing@ 2017-02-07T02:08:38+00:00 beck 2017-02-07T02:08:38+00:00 urn:sha1:9a5920738bea15430db1fdd138e67d9bbc3a95d3 Make a table of "function codes" which maps the internal state of the SSL * to something like a useful name so in a typical error in the connection you know in what sort of place in the handshake things happened. (instead of by arcane function name). Add SSLerrorx() for when we don't have an SSL * ok jsing@ after us both being prodded by bluhm@ to make it not terrible 2017-01-26T10:40:21+00:00 beck 2017-01-26T10:40:21+00:00 urn:sha1:a4abf558fd44464a5a48bfeb5393b01002f66c5e We leave a single funciton code (0xFFF) to say "SSL_internal" so the public API will not break, and we replace all internal use of the two argument SSL_err() with the internal only SSL_error() that only takes a reason code. ok jsing@ 2017-01-26T09:16:01+00:00 jsing 2017-01-26T09:16:01+00:00 urn:sha1:b7978753e566fd60946300b252a9d9d89559733e ok beck@ 2017-01-26T07:20:57+00:00 beck 2017-01-26T07:20:57+00:00 urn:sha1:698e7d8ee2f7d9cae52e8401e27ba90fcb092eac before yielding, and fail if we exceed a maximum. loosely based on what boring and openssl are doing ok jsing@ 2015-02-22T15:54:27+00:00 jsing 2015-02-22T15:54:27+00:00 urn:sha1:1b087adcf5d3e3b653d1d37eb198d47d73c1e448 This allows for clients that willingly choose to perform a downgrade and attempt to establish a second connection at a lower protocol after the previous attempt unexpectedly failed, to be notified and have the second connection aborted, if the server does in fact support a higher protocol. TLS has perfectly good version negotiation and client-side fallback is dangerous. Despite this, in order to maintain maximum compatability with broken web servers, most mainstream browsers implement this. Furthermore, TLS_FALLBACK_SCSV only works if both the client and server support it and there is effectively no way to tell if this is the case, unless you control both ends. Unfortunately, various auditors and vulnerability scanners (including certain online assessment websites) consider the presence of a not yet standardised feature to be important for security, even if the clients do not perform client-side downgrade or the server only supports current TLS protocols. Diff is loosely based on OpenSSL with some inspiration from BoringSSL. Discussed with beck@ and miod@. ok bcook@ 2014-12-14T15:30:50+00:00 jsing 2014-12-14T15:30:50+00:00 urn:sha1:0a332f7b1f3c6198783e4a2fce3186bf5914e5b9