openbsd/src/lib/libssl/ssl_pkt.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2020-08-30T15:40:20+00:00Start replacing the existing TLSv1.2 record layer.2020-08-30T15:40:20+00:00jsing2020-08-30T15:40:20+00:00urn:sha1:5df2cd671a3bb55e3ec34638a6a36eef237c529f
This takes the same design/approach used in TLSv1.3 and provides an
opaque struct that is self contained and cannot reach back into other
layers. For now this just implements/replaces the writing of records
for DTLSv1/TLSv1.0/TLSv1.1/TLSv1.2. In doing so we stop copying the
plaintext into the same buffer that is used to transmit to the wire.
ok inoguchi@ tb@
Fix some wrapping/indent.2020-08-09T16:54:16+00:00jsing2020-08-09T16:54:16+00:00urn:sha1:f7a3bcd050b34ddcb4d801a9c00fb913f5266db3Use CBB more correctly when writing SSL3/DTLS records.2020-08-09T16:02:58+00:00jsing2020-08-09T16:02:58+00:00urn:sha1:e8a20f5bda4b54bf67bf267175b38eb299dfafa9
Previously we used CBB to build the record headers, but not the entire
record. Use CBB_init_fixed() upfront, then build the record header and
add space for the record content. However, in order to do this we need
to determine the length of the record upfront.
This simplifies the code, removes a number of manual bounds checks and
makes way for further improvements.
ok inoguchi@ tb@
Check the return value of tls1_enc() in the write path.2020-08-02T07:33:15+00:00jsing2020-08-02T07:33:15+00:00urn:sha1:59487ec2a7eb6c7372b491b9191727c1f471598d
The write path can return a failure in the AEAD path and there is no reason
not to check a return value.
Spotted by tb@ during another review.
ok tb@
Clean up/simplify more of the dtls1/ssl3 record writing code:2020-08-01T16:50:16+00:00jsing2020-08-01T16:50:16+00:00urn:sha1:2ce291e2b55d3fcbf2c75812e85cfc999679a64a
- Make the DTLS code much more consistent with the ssl3 code.
- Avoid assigning wr->input and wr->length just so they can be used as
arguments to memcpy().
- Remove the arc4random_buf() call for the explicit IV, since tls1_enc()
already does this for us.
ok tb@
Pull record version selection code up and pass it as an argument to2020-08-01T16:38:17+00:00jsing2020-08-01T16:38:17+00:00urn:sha1:5ef945c253a707ecf7bc4f821caf35cfa3d672e3
ssl3_create_record().
ok tb@
Clean up and simplify some of the SSL3/DTLS1 record writing code.2020-07-30T16:53:01+00:00jsing2020-07-30T16:53:01+00:00urn:sha1:d910880213a7777e54b896e5bd7ba68cc9a09bf0
This will allow for further changes to be made with less complexity and
easier review.
In particular, decide if we need an empty fragment early on and only do
the alignment calculation once (rather than in two separate parts of the
function.
ok tb@ inoguchi@
Consistently spell 'unsigned' as 'unsigned int', as style(9) seems2020-03-16T15:25:14+00:00tb2020-03-16T15:25:14+00:00urn:sha1:168e0561df78f7340b3a674c6ffe771fb5b4bbb2
to prefer that. No binary change except in d1_srtp.c where the
generated assembly differs only in line numbers (due to a wrapped
long line) and in s3_cbc.c where there is no change in the generated
assembly.
ok inoguchi jsing
Stop overloading the record type for padding length.2020-03-12T17:09:02+00:00jsing2020-03-12T17:09:02+00:00urn:sha1:090aa8eb50273dd73eaba4ac5362be86b97cd254
Currently the CBC related code stuffs the padding length in the upper bits
of the type field... stop doing that and add a padding_length field to the
record struct instead.
ok inoguchi@ tb@
Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.2020-03-12T17:01:53+00:00jsing2020-03-12T17:01:53+00:00urn:sha1:63b0f131cbf0e20ff888516045c6693e8515333f
SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in
public headers, even though their usage is internal. This moves to
using _INTERNAL suffixed versions that are in internal headers, which
then allows us to change them without any potential public API fallout.
ok inoguchi@ tb@