A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2020-09-11T17:36:27+00:00 2020-09-11T17:36:27+00:00 jsing 2020-09-11T17:36:27+00:00 urn:sha1:cb4349853bf54ac34c4b6615aa3102e8d10f685f When parsing a cipher string, a cipher list is created, before being duplicated and sorted - the second copy being stored as cipher_list_by_id. This is done only so that a client can ensure that the cipher selected by a server is in the cipher list. This is pretty pointless given that most clients are short-lived and that we already had to iterate over the cipher list in order to build the client hello. Additionally, any update to the cipher list requires that cipher_list_by_id also be updated and kept in sync. Remove all of this and replace it with a simple linear scan - the overhead of duplicating and sorting the cipher list likely exceeds that of a simple linear scan over the cipher list (64 maximum, more typically ~9 or so). ok beck@ tb@ 2020-07-03T04:12:51+00:00 tb 2020-07-03T04:12:51+00:00 urn:sha1:3634005e8a2051a239211f692a45371c14e9d8e4 Move is_server and msg_type right after the SSL object so that CBS and CBB and alert come last. This brings these functions more in line with other internal functions and separates state from data. requested by jsing 2020-06-04T18:41:42+00:00 tb 2020-06-04T18:41:42+00:00 urn:sha1:73803d4f9471a320c132894319e7be48ead70aa3 This allows clients to use EC certificates. ok inoguchi, jsing 2020-05-23T11:58:46+00:00 jsing 2020-05-23T11:58:46+00:00 urn:sha1:b7886785c522527763ee1154ed9eb1f384cb90fe ok beck@ inoguchi@ tb@ 2020-05-19T16:35:21+00:00 jsing 2020-05-19T16:35:21+00:00 urn:sha1:369bbcd163f15f6e452e14282f0a65dafde2f5ab Some time prior to SSLeay 0.8.1b, SSL_PKEY_RSA_SIGN got added with the intention of handling RSA sign only certificates... this incomplete code had the following comment: /* check to see if this is a signing only certificate */ /* EAY EAY EAY EAY */ And while the comment was removed in 2005, the incomplete RSA sign-only handling has remained ever since. Remove SSL_PKEY_RSA_SIGN and rename SSL_PKEY_RSA_ENC to SSL_PKEY_RSA. While here also remove the unused SSL_PKEY_DH_RSA. ok tb@ 2020-05-19T01:30:34+00:00 beck 2020-05-19T01:30:34+00:00 urn:sha1:e91cca87b14fd6699247757d10bb6df50becf339 messages with oscp staples. ok jsing@ tb@ 2020-05-17T14:26:15+00:00 jsing 2020-05-17T14:26:15+00:00 urn:sha1:ce127c177d706b882344b219271b26080aea2efe According to RFC 8446 section 4.4.2.4, a client receiving an empty certificate list must abort the handshake with a decode error alert. ok beck@ inoguchi@ tb@ ('it rarely is the alert you'd expect it to be...') 2020-05-16T14:44:55+00:00 jsing 2020-05-16T14:44:55+00:00 urn:sha1:5c53acc6f2d8bb7bc7f1b005a980ccf36e27df34 The RFC requires that a server always provide a certificate for authentication. Ensure that this is the case, rather than proceeding and attempting validation. In the case where validation was disabled and the server returned an empty certificate list, this would have previously resulted in a NULL pointer deference. Issue reported by otto@ ok inoguchi@ tb@ 2020-05-13T17:51:48+00:00 jsing 2020-05-13T17:51:48+00:00 urn:sha1:ba1709c6646816bffd9caeb42503abf95c44e3e2 Switch the legacy version when processing the server hello, rather than when the client hello has been sent. This ensures that we accept a response from the server that has a record version other than TLS1_2_VERSION, as is the case where the server is negotiating TLSv1.0 or TLSv1.1. Issue spotted by inoguchi@ ok inoguchi@ tb@ 2020-05-10T16:56:11+00:00 jsing 2020-05-10T16:56:11+00:00 urn:sha1:b31d318d829815c32911ba41253883a36be79792 Rather than using a mess of SSL_AL_*, SSL_AD_*, SSL3_AD_* and TLS1_AD_* defines, provide our own TLS13_ALERT_* defines and use those. This also provides the alerts that are new to TLSv1.3. ok beck@