openbsd/src/lib/libssl/tls13_key_schedule.c, branch OPENBSD_7_9 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9 2022-11-26T16:08:57+00:00 Make internal header file names consistent 2022-11-26T16:08:57+00:00 tb 2022-11-26T16:08:57+00:00 urn:sha1:81d98bf600a381a625eb11b39a725b08c0ba547f Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names used for internal headers. Move all these headers we inherited from OpenSSL to *_local.h, reserving the name *_internal.h for our own code. Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h. constant_time_locl.h is moved to constant_time.h since it's special. Adjust all .c files in libcrypto, libssl and regress. The diff is mechanical with the exception of tls13_quic.c, where #include <ssl_locl.h> was fixed manually. discussed with jsing, no objection bcook Move tls13_exporter() code. 2022-11-07T11:53:39+00:00 jsing 2022-11-07T11:53:39+00:00 urn:sha1:e36eecc7ffab11a2e657085c0dd914fcc96f359b It makes more sense to have tls13_exporter() in tls13_key_schedule.c, rather than tls13_lib.c ok tb@ Error out if the out secret wasn't properly initialized 2022-10-14T06:56:33+00:00 tb 2022-10-14T06:56:33+00:00 urn:sha1:4afadc9acdc3f71ccd29daea6ad1b6aaeb47af1b Calling HKDF_expand() with a length of 0 happens to succeed due to a quirk in the API inherited from BoringSSL. This hides caller-side errors during development. Error out to catch such mistakes early on. ok jsing Initialize hkdf_label to NULL. 2022-07-07T17:09:45+00:00 tb 2022-07-07T17:09:45+00:00 urn:sha1:686ff565bc422724b901776b403c7211f100d822 Needed for an upcoming diff adding a NULL check to CBB_finish(). ok jsing Avoid local variable in tls13_secret_init(). 2021-01-05T18:36:22+00:00 tb 2021-01-05T18:36:22+00:00 urn:sha1:ebfbbb1573214760116ca552af6e7066e95c7d8f suggested by jsing Use KNF for licence comment 2021-01-05T17:46:32+00:00 tb 2021-01-05T17:46:32+00:00 urn:sha1:957c4e9dec76a4783297cb94a41ffd1f67de93ba ok jsing Move tls13_secrets_destroy() below _create() 2021-01-05T17:45:32+00:00 tb 2021-01-05T17:45:32+00:00 urn:sha1:87d1b08492e5a4b58d665fe9067fb0397da66bbd ok jsing Convert tls13_secrets_{create,destroy}() to tls13_secret_{init,cleanup}() 2021-01-05T17:43:13+00:00 tb 2021-01-05T17:43:13+00:00 urn:sha1:fab56523f6b20caed800c1ef4d522a9bf86b115f ok jsing Add tls13_secret_{init,cleanup}() 2021-01-05T17:40:11+00:00 tb 2021-01-05T17:40:11+00:00 urn:sha1:98ed5a11185e1e013dd02ad00f377be86a157f5d These are two functions that will help streamlining various functions in the TLSv1.3 code that do not need to know about the interna of this struct. input/ok jsing Implement exporter for TLSv1.3. 2020-11-16T18:55:15+00:00 jsing 2020-11-16T18:55:15+00:00 urn:sha1:97a181ebd909bb90e14296e0f9b4e74645c26398 This implements the key material exporter for TLSv1.3, as defined in RFC8446 section 7.5. Issue reported by nmathewson on github. ok inoguchi@ tb@