openbsd/src/lib/libssl/tls13_legacy.c, branch OPENBSD_6_8_BASE

Improve handling of BIO_read()/BIO_write() failures in the TLSv1.3 stack.

2020-09-13T15:04:35+00:00

When BIO returns a failure, it does not always add an error to the error stack. In the case of the legacy stack, this was generally handled by the guesswork performed by SSL_get_error(). However, in the case of the new stack we push an 'unknown' error onto the stack. Improve this situation by specifically checking errno in the case of a BIO_read() or BIO_write() failure. If the error stack is empty then push a SYSerror() with the errno which is preferable to the 'unknown' error later. Noted by bluhm@ via syslogd regress. ok beck@ tb@

Have ssl_init_wbio_buffer() push the buffering BIO rather than doing it

2020-07-30T16:57:53+00:00

ourselves. Spotted by tb@ during a previous review.

Handle SSL_MODE_AUTO_RETRY being changed during a TLSv1.3 session.

2020-07-25T17:44:30+00:00

Both Perl's HTTP::Tiny and IO::Socket::SSL know about SSL_MODE_AUTO_RETRY and try to work around the fact that OpenSSL enabled it by default. However, this can lead to the mode being disabled prior to the TLSv1.3 handshake and then enabled after the handshake has completed. In order to handle this correctly we have to check the mode and inform the record layer prior to every read. Issue reported and test case provided by Nathanael Rensen . ok inoguchi@ tb@

Dedup the use legacy stack code.

2020-07-14T18:55:59+00:00

ok inoguchi@ tb@

Make tls13_legacy_shutdown() match ssl3_shutdown() semantics.

2020-06-24T18:04:33+00:00

When first called, queue and send a close notify, before returning 0 or 1 to indicate if a close notify has already been received from the peer. If called again only attempt to read a close notify if there is no pending application data and only read one record from the wire. In particular, this avoids continuing to read application data where the peer continues to send application data. Issue noted by naddy@ with ftp(1). ok jca@ tb@

Wire up the servername callback in the TLSv1.3 server.

2020-05-29T17:47:30+00:00

This makes SNI work correctly with TLSv1.3. Found the hard way by danj@, gonzalo@ and others. ok beck@ inoguchi@ tb@

Add TLS13_ERR_NO_CERTIFICATE.

2020-05-16T14:42:35+00:00

This was missed in previous tls13_server.c commit. ok inoguchi@ tb@

Provide an alert sent record layer callback.

2020-05-11T17:46:46+00:00

Use this to push an error on to the SSL error stack so that we report the details of the alert that we sent, rather than failing with an unknown error. ok tb@

Honour SSL_VERIFY_FAIL_IF_NO_PEER_CERT in the TLSv1.3 server.

2020-05-10T16:59:51+00:00

ok beck@

Provide alert defines for TLSv1.3 and use in the TLSv1.3 code.

2020-05-10T16:56:11+00:00

Rather than using a mess of SSL_AL_*, SSL_AD_*, SSL3_AD_* and TLS1_AD_* defines, provide our own TLS13_ALERT_* defines and use those. This also provides the alerts that are new to TLSv1.3. ok beck@