openbsd/src/lib/libssl/tls13_lib.c, branch OPENBSD_6_8_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE2020-09-11T15:03:36+00:00Some SSL_AD_* defines snuck into the TLSv1.3 code - replace them with2020-09-11T15:03:36+00:00jsing2020-09-11T15:03:36+00:00urn:sha1:36ef385543a54e60c5f363ee7e5af9f2c04097d7
TLS13_ALERT_* defines.
ok beck@ tb@
Add minimal info callback support for TLSv1.32020-07-30T16:23:17+00:00tb2020-07-30T16:23:17+00:00urn:sha1:d72120f6c7c798dbddfd43101f7adba6a8f598e0
As abieber@ found the hard way, some python frameworks (twisted, synapse)
thought it a great idea to use the info callback mechanism (designed to
get state information about SSL objects) to modify state information such
as setting and verifying the SNI. The switch of TLS_method() to default
to TLSv1.3 broke these contraptions. Further bits of the info callback
mechanism will likely metastasize throughout the TLSv1.3 stack if we
need them, so we only do what's really necessary now.
Lots of debugging, crucial hint and testing by abieber
input & ok jsing
Improve argument order for the internal tlsext API2020-07-03T04:12:51+00:00tb2020-07-03T04:12:51+00:00urn:sha1:3634005e8a2051a239211f692a45371c14e9d8e4
Move is_server and msg_type right after the SSL object so that CBS
and CBB and alert come last. This brings these functions more in
line with other internal functions and separates state from data.
requested by jsing
Implement a rolling hash of the ClientHello message, Enforce RFC 84462020-06-06T01:40:09+00:00beck2020-06-06T01:40:09+00:00urn:sha1:2d835ca8318d9ce502e9fd2dced3ef440decb39d
section 4.1.2 to ensure subsequent ClientHello messages after a
HelloRetryRequest messages must be unchanged from the initial
ClientHello.
ok tb@ jsing@
Ensure we only attach an ocsp staple to a leaf certificate, because2020-05-22T02:37:27+00:00beck2020-05-22T02:37:27+00:00urn:sha1:e59fc62eea954afd7cc756f43e59f23d4f78762f
for the moment that is all we support. fixes an issue where gnuTLS
cares that mistmatching staples come back on the certs in the chain.
This should be fixed correctly later by associating the staple
to the individual certs rather than the ssl, so this is temporary.
running on www@.
ok tb@, "got that's oopy but an interim ok" jsing@
Simplify: transform a dangling else into an early return and2020-05-21T19:43:40+00:00tb2020-05-21T19:43:40+00:00urn:sha1:a320e254d2c6bc047fd85ce8ccfe41ddb62f30e1
unindent a bunch of code.
Suggested by jsing
Avoid a shadowing issue by renaming cbs and cbb to cbb_hs and cbb_hs,2020-05-21T19:27:22+00:00tb2020-05-21T19:27:22+00:00urn:sha1:b6f84515fb35d376ad9e98f15bbc174521ff1dc8
respectively.
Discussed with jsing
A failure of tls13_handshake_msg_new() could lead to a NULL deref2020-05-21T19:15:54+00:00tb2020-05-21T19:15:54+00:00urn:sha1:40ba02cc6b28bca820a5fa8b6f44161e0ef5aa84
in the following tls13_handshake_msg_start() call. Add a check.
Stop clobbering the ctx's hs_msg variable, use a local variable
instead.
ok beck jsing
Add support for TLS 1.3 server to send certificate status2020-05-19T01:30:34+00:00beck2020-05-19T01:30:34+00:00urn:sha1:e91cca87b14fd6699247757d10bb6df50becf339
messages with oscp staples.
ok jsing@ tb@
Send alerts back correctly when handling key shares, including2020-05-17T19:07:15+00:00beck2020-05-17T19:07:15+00:00urn:sha1:4a786d1c4d9d09f1e786e9d4aca6b59928465a11
sending back illegal parameter if our phh key share request type
is not 0 or 1.
ok jsing@ tb@