A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_7_1_BASE 2022-03-31T17:27:26+00:00 2022-03-31T17:27:26+00:00 naddy 2022-03-31T17:27:26+00:00 urn:sha1:3d8be07546f5ec331a0f851b0ea88212376ebb95 jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@ 2022-03-29T18:15:52+00:00 naddy 2022-03-29T18:15:52+00:00 urn:sha1:bdf85107fe61cee7a4395de94b85298d6592c8ae ok jmc@ schwarze@ 2022-03-29T14:27:59+00:00 naddy 2022-03-29T14:27:59+00:00 urn:sha1:73e6943db680ec4bee34139bfe612acbc35a84b6 2022-03-26T15:05:53+00:00 jsing 2022-03-26T15:05:53+00:00 urn:sha1:cb5a6c5bc2eacc54a81b940108d92c64bb97fed8 Now that {dtls1,ssl3}_read_bytes() have been refactored, do a clean up pass - this cleans up various parts of the code and reduces differences between these two functions. ok = 1; *(&(ok)) tb@ ok inoguchi@ 2022-03-26T15:00:51+00:00 jsing 2022-03-26T15:00:51+00:00 urn:sha1:e8857aefebcf865da68becce2239c122ddc4c51e The code that handles each record type already has appropriate length checks. Furthermore, the handling of application data here is likely incorrect and bypasses the normal state checks at the end of this function. ok inoguchi@ tb@ 2022-03-19T18:19:24+00:00 tb 2022-03-19T18:19:24+00:00 urn:sha1:99132d81f4cf448a88886cb53ca21648f19c7a06 The asn1test depends on asn1_mac.h which had a date with the bitbucket a few years back (and the test "isn't meant to run particularly, it's just to test type checking"). methtest.c tests an API that was never present in OpenSSL's git history. r160test.c is nothing but a licence. "nuke away" jsing 2022-03-18T18:01:17+00:00 jsing 2022-03-18T18:01:17+00:00 urn:sha1:c5bd1c6747cb8fb5f9c3011ba331a58d8581b85a ok inoguchi@ tb@ 2022-03-18T18:00:54+00:00 jsing 2022-03-18T18:00:54+00:00 urn:sha1:92a14733c33ea6dd1f3b317e80d3d5e3deb0c0ba Rewrite the code that handles unexpected handshake messages in the legacy DTLS stack. Parse the DTLS message header up front, then process it based on the message type. Overall the code should be more strict and we should reject various invalid messages that would have previously been accepted. ok inoguchi@ tb@ 2022-03-17T17:28:08+00:00 jsing 2022-03-17T17:28:08+00:00 urn:sha1:41a08777574d6b8a815753d8ebb8f52778eb9c53 Rewrite the code that handles unexpected handshake messages in the legacy TLS stack. Parse the TLS message header up front, then process it based on the message type. Overall the code should be more strict and we should reject various invalid messages that would have previously been accepted. I also reviewed steve's experimental code and fixed the bug that it contained. ok inoguchi@ tb@ 2022-03-17T17:24:37+00:00 jsing 2022-03-17T17:24:37+00:00 urn:sha1:36e14893d067c1a9c5b8fe272976884bf8f4c3fa ok inoguchi@ tb@