openbsd/src/lib/libssl, branch libressl-v3.1.0

Void functions obviously do not return values; no need to elaborate.

2020-03-30T10:28:59+00:00

Patch from Martin Vahlensieck .

Void functions obviously do not return values; no need to elaborate.

2020-03-29T17:05:02+00:00

Patch from Martin Vahlensieck .

Consistently spell 'unsigned' as 'unsigned int', as style(9) seems

2020-03-16T15:25:14+00:00

to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing

The RFC is clear (section 5.3) that sequence number should never wrap.

2020-03-16T15:11:35+00:00

We currently throw an error on overflow, but still wrap. Check up front if we would need to wrap and only increment if that case is excluded. This simplifies the increment loop and makes the returns in this function less magic. ok jsing

Remove dtls1_enc().

2020-03-13T16:40:42+00:00

Like much of the original DTLS code, dtls1_enc() is effectively a renamed copy of tls1_enc(). Since then tls1_enc() has been modified, however the non-AEAD code remains largely the same. As such, remove dtls1_enc() and instead call tls1_enc() from the DTLS code. The tls1_enc() AEAD code does not currently work correctly with DTLS, however this is a non-issue since we do not support AEAD cipher suites with DTLS currently. ok tb@

Correct TLSv1.3 sequence number increment and wrapping check.

2020-03-13T16:03:27+00:00

Fix proposed by tb@

Ensure that CBB_add_space() always provides zeroed memory.

2020-03-13T15:54:34+00:00

ok tb@

Use calloc() rather than malloc() when allocating initial CBB buffer.

2020-03-12T17:17:12+00:00

CBB uses recallocarray() to expand buffers, however was still using malloc() for the initial buffer, which could result in memory being leaked in incorrect use cases. While here also use calloc() to allocate internal structs. ok inoguchi@ tb@

Use calloc() rather than malloc() when allocating buffers.

2020-03-12T17:15:33+00:00

This reduces the chance of accidently leaking stack memory. ok inoguchi@ tb@

Stop overloading the record type for padding length.

2020-03-12T17:09:02+00:00

Currently the CBC related code stuffs the padding length in the upper bits of the type field... stop doing that and add a padding_length field to the record struct instead. ok inoguchi@ tb@