openbsd/src/lib, branch libressl-v2.8.0 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.8.0 2018-08-05T14:17:12+00:00 Remove unnecessary NULL check from get_cert_by_subject since 2018-08-05T14:17:12+00:00 bcook 2018-08-05T14:17:12+00:00 urn:sha1:6b472be450b41d2399d1fd32bf31177c8c24f895 sk_BY_DIR_HASH_find already does it, removing ambiguity later in the function. ok tb@ Fix a memory leak in i2d_RSA_NET on failure of ASN1_STRING_set. 2018-08-05T13:35:45+00:00 bcook 2018-08-05T13:35:45+00:00 urn:sha1:0d240c50f7f6398b6c3318757e0e84305c126bfe Found by Coverity. Feedback and ok tb@ In RSA_padding_add_PKCS1_OAEP, dbmask needs to be freed on failure. 2018-08-05T13:30:04+00:00 bcook 2018-08-05T13:30:04+00:00 urn:sha1:e194da0c9fa04c9c6ea539711965b1c64df85f0e ok tb@ Fix memory leak in i2b_PVK in error handling. 2018-08-05T11:19:25+00:00 bcook 2018-08-05T11:19:25+00:00 urn:sha1:2e290efb0ac101817d9da88a5b417f1b48cbe3fa Simplify parameter checks since this is only called from one place. Found by Coverity, CID 183502. ok beck@ Document that X509_{NAME,REQ,REQ_INFO}_free() are all NULL safe. 2018-07-29T20:29:32+00:00 tb 2018-07-29T20:29:32+00:00 urn:sha1:bc5000034af13f4c49c17dec36a14297930f86ae From Ross L. Richardson add c++ symbol annotations 2018-07-24T10:47:19+00:00 bcook 2018-07-24T10:47:19+00:00 urn:sha1:f1ec5a423eb80a4eab6359859a6bc989349df9ea from Cameron Palmer Use the same order in NAME, SYNOPSIS, DESCRIPTION, and RETURN VALUES to 2018-07-24T02:01:34+00:00 tb 2018-07-24T02:01:34+00:00 urn:sha1:94b59697fc997b93402f6846b0c90a706f050413 improve readability and ease of maintenance. Positive feedback jmc Detailed suggestion & ok schwarze Document tls_peer_ocsp_result() and use it in place of the non-existent 2018-07-23T18:30:29+00:00 tb 2018-07-23T18:30:29+00:00 urn:sha1:365b85e0fc5a1c968b45bd7be78ffca90a662d35 tls_peer_ocsp_result_msg() in the documentation. input & ok jsing Reads fine to jmc and makes sense to schwarze Use BN_swap_ct() instead of BN_consttime_swap() in 2018-07-23T18:24:22+00:00 tb 2018-07-23T18:24:22+00:00 urn:sha1:e6611a883efd7a024a8b6866fc8dd4ca468b9667 ec_GF2m_montgomery_point_multiply(). The new BN_swap_ct() API is an improved version of the public BN_consttime_swap() function: it allows error checking, doesn't assert(), and has fewer assumptions on the input. This diff eliminates the last use of BN_consttime_swap() in our tree. ok inoguchi, jsing Use a size_t instead of an int for the byte count in BN_swap_ct(). 2018-07-23T18:14:32+00:00 tb 2018-07-23T18:14:32+00:00 urn:sha1:1b961cfb65c1f00f26f20454324577edec589a1b Since bignums use ints for the same purpose, this still uses an int internally after an overflow check. Suggested by and discussed with jsing. ok inoguchi, jsing