openbsd/src/lib, branch libressl-v3.1.0

"eventually" came and went back in 2004.

2020-03-30T12:52:58+00:00

OK schwarze@

Void functions obviously do not return values; no need to elaborate.

2020-03-30T10:28:59+00:00

Patch from Martin Vahlensieck .

Void functions obviously do not return values; no need to elaborate.

2020-03-29T17:05:02+00:00

Patch from Martin Vahlensieck .

Be concise: do not say that void functions return no values, that's obvious.

2020-03-28T22:40:58+00:00

Useless text reported by Martin Vahlensieck (academicsolutions.ch) on tech@.

Fix ASN1 print functions

2020-03-24T10:46:38+00:00

Check and print out boolean type properly. Based on OpenSSL commit ad72d9fdf7709ddb97a58d7d45d755e6e0504b96. Reduced unneeded parentheses from if condition. Check return value from i2s_ASN1_INTEGER. Based on OpenSSL commit 5e3553c2de9a365479324b8ba8b998f0cce3e527. Added if condition expression and return 0 if NULL is returned. ok tb@

Consistently spell 'unsigned' as 'unsigned int', as style(9) seems

2020-03-16T15:25:14+00:00

to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing

The RFC is clear (section 5.3) that sequence number should never wrap.

2020-03-16T15:11:35+00:00

We currently throw an error on overflow, but still wrap. Check up front if we would need to wrap and only increment if that case is excluded. This simplifies the increment loop and makes the returns in this function less magic. ok jsing

Remove dtls1_enc().

2020-03-13T16:40:42+00:00

Like much of the original DTLS code, dtls1_enc() is effectively a renamed copy of tls1_enc(). Since then tls1_enc() has been modified, however the non-AEAD code remains largely the same. As such, remove dtls1_enc() and instead call tls1_enc() from the DTLS code. The tls1_enc() AEAD code does not currently work correctly with DTLS, however this is a non-issue since we do not support AEAD cipher suites with DTLS currently. ok tb@

Correct TLSv1.3 sequence number increment and wrapping check.

2020-03-13T16:03:27+00:00

Fix proposed by tb@

Ensure that CBB_add_space() always provides zeroed memory.

2020-03-13T15:54:34+00:00

ok tb@