openbsd/src/lib, branch libressl-v3.3.0A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v3.3.02020-11-20T08:08:02+00:00fix another misleading line break and indent2020-11-20T08:08:02+00:00tb2020-11-20T08:08:02+00:00urn:sha1:0068cc3650e1a212d865b7843ac3d0f02acce643fix confusing line break and indent2020-11-20T08:03:53+00:00tb2020-11-20T08:03:53+00:00urn:sha1:57ee25f03699dffb7ef2796fd99109733617f757Plug leak in x509_verify_chain_dup()2020-11-18T17:54:46+00:00tb2020-11-18T17:54:46+00:00urn:sha1:d7ea65d1de4c5d0528a68eb9b33a6ef17ca79f14
x509_verify_chain_new() allocates a few members of a certificate chain:
an empty stack of certificates, a list of errors encountered while
validating the chain, and a list of name constraints. The function to
copy a chain would allocate a new chain using x509_verify_chain_new()
and then clobber its members by copies of the old chain. Fix this by
replacing x509_verify_chain_new() with calloc().
Found by review while investigating the report by Hanno Zysik who
found the same leak using valgrind. This is a cleaner version of
my initial fix from jsing.
ok jsing
Plug a big memory leak in the new validator2020-11-18T17:40:42+00:00tb2020-11-18T17:40:42+00:00urn:sha1:fa7f97be6a425fa454c92d146ea0a205a46da2a0
The legacy validator would only call x509_vfy_check_policy() once at
the very end after cobbling together a chain. Therefore it didn't
matter that X509_policy_check() always allocates a new tree on top of
the one that might have been passed in. This is in stark contrast to
other, similar APIs in this code base. The new validator calls this
function several times over while building its chains. This adds up
to a sizable leak in the new validator.
Reported with a reproducer by Hanno Zysik on github, who also bisected
this to the commit enabling the new validator.
Narrowed down to x509_vfy_check_policy() by jsing.
We simultaenously came up with a functionally identical fix.
ok jsing
zap ugly empty line before closing brace2020-11-18T17:13:55+00:00tb2020-11-18T17:13:55+00:00urn:sha1:644cb0c3bf194db22125d9f1f2bb4fbdad279d65Move freeing of the verify context to its natural place instead of2020-11-18T17:08:59+00:00tb2020-11-18T17:08:59+00:00urn:sha1:3bc85c50efd5da6e970a3a4b0bf1d312386c6327
a few lines after.
stylistic nit from jsing
KNF (whitespace)2020-11-18T17:00:59+00:00tb2020-11-18T17:00:59+00:00urn:sha1:05555ab1add6e7a31798831da9ff788048d1b3cfbump to 3.3.02020-11-18T11:10:08+00:00bcook2020-11-18T11:10:08+00:00urn:sha1:047724b70558e5801fecc261c89babf45511d99etypo & punctuation in comment2020-11-17T07:02:30+00:00tb2020-11-17T07:02:30+00:00urn:sha1:774388b1d62441f5f00ea24f86e824a2a113c79aImplement exporter for TLSv1.3.2020-11-16T18:55:15+00:00jsing2020-11-16T18:55:15+00:00urn:sha1:97a181ebd909bb90e14296e0f9b4e74645c26398
This implements the key material exporter for TLSv1.3, as defined in
RFC8446 section 7.5.
Issue reported by nmathewson on github.
ok inoguchi@ tb@