openbsd/src/lib, branch libressl-v3.3.4A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=libressl-v3.3.42021-08-20T19:54:59+00:00In LibreSSL, printing a certificate can result in a crash in2021-08-20T19:54:59+00:00benno2021-08-20T19:54:59+00:00urn:sha1:3627e057ddf00759d5985e80a8bb317a1b071a4a
X509_CERT_AUX_print().
Commit in -current:
CVSROOT: /cvs
Module name: src
Changes by: schwarze@cvs.openbsd.org 2021/07/10 11:45:16
Modified files:
lib/libcrypto/asn1: t_x509a.c
Log message:
Fix a read buffer overrun in X509_CERT_AUX_print(3),
which by implication also affects X509_print(3).
The ASN1_STRING_get0_data(3) manual explitely cautions the reader
that the data is not necessarily NUL-terminated, and the function
X509_alias_set1(3) does not sanitize the data passed into it in
any way either, so we must assume the alias->data field is merely
a byte array and not necessarily a string in the sense of the C
language.
I found this bug while writing manual pages for these functions.
OK tb@
As an aside, note that the function still produces incomplete and
misleading results when the data contains a NUL byte in the middle
and that error handling is consistently absent throughout, even
though the function provides an "int" return value obviously intended
to be 1 for success and 0 for failure, and even though this function
is called by another function that also wants to return 1 for success
and 0 for failure and even does so in many of its code paths, though
not in others. But let's stay focussed. Many things would be nice
to have in the wide wild world, but a buffer overflow must not be
allowed to remain in our backyard.
This is patches/6.9/common/015_x509.patch.sig
mention DTLS1_2_VERSION2021-04-15T16:43:27+00:00tb2021-04-15T16:43:27+00:00urn:sha1:e8f5d300c023c6ce39600d797f14aad30480c218Mention DTLS1_2_VERSION here, too2021-04-15T16:40:32+00:00tb2021-04-15T16:40:32+00:00urn:sha1:d9e6b3c687e1354c4e1cad55cbcab90c57b88e22Document SSL_OP_NO_DTLSv1{,_2}2021-04-15T16:35:54+00:00tb2021-04-15T16:35:54+00:00urn:sha1:f84b114c13dd506177484d1d3d884decd7f8fc49Document DTLSv1_2_{,client_,server_}method(3)2021-04-15T16:30:14+00:00tb2021-04-15T16:30:14+00:00urn:sha1:e3838fdc2a1003bcdb4b3974b84cac83f1360f3fMerge documentation for SSL_is_dtls() from OpenSSL2021-04-15T16:13:22+00:00tb2021-04-15T16:13:22+00:00urn:sha1:ac21a57498563a5b644578b3012a2748d9c5eee0Switch back to the legacy verifier for the release.2021-04-15T14:15:03+00:00tb2021-04-15T14:15:03+00:00urn:sha1:013c39e97f0af8342cdb560b4a2a45f87602f7b7
This is disappointing as a lot of work was put into the new verifier
during this cycle. However, there are still too many known bugs and
incompatibilities. It is better to be faced with known broken behavior
than with new broken behavior and to switch now rather than via errata.
This way we have another cycle to iron out the kinks and to fix some of
the remaining bugs.
ok jsing
Update a stale comment and fix a typo.2021-04-11T07:06:01+00:00tb2021-04-11T07:06:01+00:00urn:sha1:7d1a2a60100b5104532cc2cc1b5d6f28551be015An extra internal consistency check and a missing stats adjustment. ok tb@2021-04-09T06:05:21+00:00otto2021-04-09T06:05:21+00:00urn:sha1:b4499c43f4b32d2e5e054187f8f0e5bfd8299e02Cache implementation has changed, we do not hold on to an exact number2021-04-09T06:04:15+00:00otto2021-04-09T06:04:15+00:00urn:sha1:e3d1ed16d000aa151144fb4a5e41cd02144b2cc2
of pages anymore, but also cache larger regions; ok tb@