A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=master 2026-01-04T09:51:42+00:00 2026-01-04T09:51:42+00:00 tb 2026-01-04T09:51:42+00:00 urn:sha1:f65bd896414ed2e25bad00527fa4f1c5fabdad09 A nasty quirk in the bit string handling is that the serialization produced by i2d_ASN1_BIT_STRING() depends on whether the the magic ASN1_STRING_FLAG_BITS_LEFT is set. If ASN1_STRING_FLAG_BITS_LEFT is set, the number of unused bits is carried in a->flags & 0x07 and the remainder of the bit string is in a->data. This is terrible and undocumented but handled correctly. If ASN1_STRING_FLAG_BITS_LEFT is not set, all trailing zero bits are (intended to be) chopped off with all sorts of hilarious side effects. I broke this quite thoroughly when I incorrectly ported an overflow check from BoringSSL in: https://github.com/openbsd/src/commit/f81cc285d2aed8b36615119a306533696f3eb66c The result is that we currently return ret = a->length + 1 for both NULL and non-NULL pp. The calls to asn1_ex_i2c() in asn1_i2d_ex_primitive() thus report consistent lengths back, making it succeed. asn1_i2d_ex_primitive() therefore skips a->length + 1 bytes, while i2c_ASN1_BIT_STRING() only overwrites len + 1 bytes, which are possibly fewer. So a caller passing in an output buffer containing garbage (malloc) will get some of that garbage back in the encoding. Further, i2c_ASN1_BIT_STRING() also advances that pointer by the possibly reduced len + 1, but that fortunately doesn't matter since that's an effect local to asn1_ex_i2c(), the only caller of i2c_ASN1_BIT_STRING(). The last bit is that the current behavior may set bogus unused bits coming from the scanning backward madness. I added such an example in the parent commit. The fix is simple: use len after the truncation effect was established, not the original a->length, turning this commit into what my backport should have been. This fixes the two currently failing regress tests, so remove expected failure marker again. ok jsing kenjiro 2026-01-04T09:43:52+00:00 tb 2026-01-04T09:43:52+00:00 urn:sha1:e25ccd667e01e3a9e37f06e7cc79fb7ac0f6e3f4 This is another test that fails due to the bug in i2c_ASN1_BIT_STRING(). 2026-01-04T09:42:32+00:00 tb 2026-01-04T09:42:32+00:00 urn:sha1:d35a685166b500418ee47359c5cfcd27c97b3eae This test fails, so mark the asn1basic test as an expected failure 2026-01-04T09:36:34+00:00 tb 2026-01-04T09:36:34+00:00 urn:sha1:92a00177b1792955d45f8653ea60eb986b21c90a There is a bug in i2c_ASN1_BIT_STRING() resulting in nonsense encoding of some BIT STRINGs with trailing zeroes if ASN1_STRING_FLAG_BITS_LEFT is not set (a rare corner case). This test currently passes when it shouldn't. 2025-12-18T09:15:28+00:00 tb 2025-12-18T09:15:28+00:00 urn:sha1:2681c4505dbb93940f461387b894b73e6ffedaff Exercises the batshit crazy truncation behavior of ASN1_BIT_STRING_set_bit() Based on https://boringssl-review.googlesource.com/c/boringssl/+/48225 (still under ISC). 2025-12-07T09:35:20+00:00 tb 2025-12-07T09:35:20+00:00 urn:sha1:b5b75e6cf83ebe9db12ceae1310ec8c4717af461 2025-05-22T04:54:14+00:00 joshua 2025-05-22T04:54:14+00:00 urn:sha1:2d4388ef345bddaf009d20ea924bb76d9d803be6 Previously, invalid generalized time tests were split into a separate set of test vectors and a flag was used when calling the test function to indicate they should be tested as generalized only. This simplifies the code a bit, and makes converting to the new test framework easier. ok jsing 2025-02-26T09:57:39+00:00 tb 2025-02-26T09:57:39+00:00 urn:sha1:472c19f8213572489b9c799c51c1c4c1f54469f9 From Kenjiro Nakayama 2024-07-21T13:25:11+00:00 tb 2024-07-21T13:25:11+00:00 urn:sha1:e9d81543648b215b7a990d14f1ec580de42eff13 extracted from a diff by Kenjiro Nakayama 2024-05-29T17:23:05+00:00 tb 2024-05-29T17:23:05+00:00 urn:sha1:48544c515c7eb12f6d6f680bd1432c6912e981e1