openbsd/src/regress/lib/libssl/bytestring, branch libressl-v2.2.7 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v2.2.7 2015-07-31T14:18:06+00:00 Don't hardcode /usr/src, use BSDSRCDIR 2015-07-31T14:18:06+00:00 tobiasu 2015-07-31T14:18:06+00:00 urn:sha1:4483a672cc23295384960c87b1929e13ae60dba8 simplify length checking in do_indefinite_convert 2015-07-18T21:57:00+00:00 bcook 2015-07-18T21:57:00+00:00 urn:sha1:0754ae5beb3c90c42a4f025ab0840aca20f65390 Fixes Coverity 117506, 117507, 117508 ok doug@ Change CBS_dup() to also sync the offset. 2015-06-23T05:58:28+00:00 doug 2015-06-23T05:58:28+00:00 urn:sha1:9a31903e554f01ace552d6ed0a48e3af5e464664 Previously, CBS_dup() had its own offset. However, it is more consistent to copy everything. ok miod@ jsing@ Convert bytestringtest to individual checks and don't short circuit. 2015-06-23T01:20:24+00:00 doug 2015-06-23T01:20:24+00:00 urn:sha1:84ef3d24fb4f24599400c3ca9569f6d0ba74b2bf The statements were chained together with OR which makes it more annoying to debug. Also, it was short circuiting all tests as soon as one function failed. Since the functions are independent, they should each run until error. Discussed with miod@ and jsing@ Remove unnecessary regress target. 2015-06-23T00:02:01+00:00 doug 2015-06-23T00:02:01+00:00 urn:sha1:76830927a2141b0895f5f91362d3e8480143efb2 Add tests for CBS_offset() and CBS_write_bytes(). 2015-06-17T07:15:52+00:00 doug 2015-06-17T07:15:52+00:00 urn:sha1:2e34e7894def0bc4b48f5c6a0e01d829aed13fa4 "no problem" miod@, tweak + ok jsing@ Be more strict about BER and DER terminology. 2015-06-16T06:37:58+00:00 doug 2015-06-16T06:37:58+00:00 urn:sha1:b87417588144066bdf43f4c7eaed221f27269c8f bs_ber.c does not convert BER to DER. It's a hack to convert a DER-like encoding with one violation (indefinite form) to strict DER. Rename the functions to reflect this. ok miod@ jsing@ Check for invalid leading zeros in CBS_get_asn1_uint64. 2015-04-25T15:28:47+00:00 doug 2015-04-25T15:28:47+00:00 urn:sha1:14b4339c31e6165fb11bbb889e4b24b201ac5e29 ASN.1 integers cannot have all zeros or all ones for the first 9 bits. This rule ensures the numbers are encoded with the smallest number of content octets (see ITU-T Rec X.690 section 8.3.2). Based on BoringSSL commit 5933723b7b592e9914f703d630b596e140c93e16 ok deraadt@ jsing@ Add more error checking and free resources in bytestringtest. 2015-02-16T06:48:17+00:00 doug 2015-02-16T06:48:17+00:00 urn:sha1:7b9469d42e3e55b355bdc3e71d8893d3ca583be1 KNF bytestring files. 2015-02-06T22:22:33+00:00 doug 2015-02-06T22:22:33+00:00 urn:sha1:d03a4807083e9e8c5b74ea28b35bf911945962ec I checked that this doesn't change anything. Compiled with clang using -Wno-pointer-sign -g0 to reduce the differences. Only difference in the asm is due to assert(0) line number changes in bs_cbs.c and bs_cbb.c. miod is ok with the general process.