openbsd/src/regress, branch tb_20230422A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=tb_202304222023-04-23T13:43:47+00:00This commit was manufactured by cvs2git to create tag 'tb_20230422'.2023-04-23T13:43:47+00:00cvs2svnadmin@example.com2023-04-23T13:43:47+00:00urn:sha1:e2496982472bdf233be95c5ea72d1c4dc6c91db3Import C2SP/CCTV test2023-04-23T13:43:46+00:00tb2023-04-23T13:43:46+00:00urn:sha1:097d0cf840b9007212bcd2516ed5e18939e6da3d
This currently only covers Ed25519 using the c2sp-testvectors package
and checks that our Ed25519 implementation behaves as expected from a
"ref10" implementation.
This test has Go and c2sp-testvectors as a hard dependency. It will
optionally pick up any OpenSSL package installed on the system and
test that as well.
https://github.com/C2SP/CCTV
https://github.com/C2SP/CCTV/tree/main/ed25519
Provide initial regress for BN_{asc,dec,hex}2bn()/BN_bn2{dec,hex}()2023-04-22T14:03:03+00:00jsing2023-04-22T14:03:03+00:00urn:sha1:38628b8b7ea8c26653d832fbfd401a1b107816a0Exercise d2i_IPAddrBlocks() and X509v3_addr_subset() a little bit2023-04-20T07:39:17+00:00tb2023-04-20T07:39:17+00:00urn:sha1:d6b160ce6ee43dfa5c92cb3241d07398aa721b0finterop: work around extreme REGRESS_SKIP_SLOW slowness2023-04-19T15:34:23+00:00tb2023-04-19T15:34:23+00:00urn:sha1:73798ebfda5eeaa9a9f42af994c4ac301b83b075
A few years back beck introduced REGRESS_SKIP_SLOW dances with the idea
that this should speed up the interop tests for us devs because this also
checked interop between opensslX and opensslY, which we don't particularly
care about. This never really worked. On a mac m1 mini the result is this:
REGRESS_SKIP_SLOW unset
9m56.69s real 3m42.24s user 3m00.70s system
REGRESS_SKIP_SLOW=yes
11m04.61s real 7m29.61s user 1m40.29s system
The problem is that REGRESS_SKIP_SLOW simply wasn't designed to handle
the huge number of tests we have here. There are many nested .for loops
resulting in several thousand tests. Each test has a name of length ~80.
REGRESS_SKIP_SLOW concatenates them into a several hundred kilobytes
long string in REGRESS_SKIP_TARGETS, iterates over all regress targets and
tests with ".if ${REGRESS_SKIP_TARGETS:M${RT}}" if it should skip them.
This means that during a regress run, make spends a lot of time linearly
scanning a huge string.
I ran into this when I added OpenSSL 3.0 tests to the already existing
1.0.2 and 1.1 tests with the result that with REGRESS_SLOW_TARGTS set
it took the better part of an hour while without it it took about 15 min.
The hack here is simply to avoid using REGRESS_SLOW_TARGTES here and
handle the situation differently.
patch, REGRESS_SKIP_SLOW=yes
5m42.32s real 2m09.98s user 1m45.21s system
The real solution would be to fix this in bsd.regress.mk, which someone
who understands make well is very welcome to do. For now, I'm happy with
this.
Debugged with jsing a few months ago
remove duplicate includes2023-04-19T12:58:16+00:00jsg2023-04-19T12:58:16+00:00urn:sha1:66b857bfb31c84024d348c1b47c595ee2d24262fectest: Remove #if 12023-04-18T15:28:17+00:00tb2023-04-18T15:28:17+00:00urn:sha1:41758b9dafcd8fa5159b339824c184f36a2593eaUnifdef OPENSSL_NO_EC_NISTP_64_GCC_1282023-04-18T15:20:34+00:00tb2023-04-18T15:20:34+00:00urn:sha1:9a6247d4aa689a82c59fb459a1e55f0e2552e1d8ectest: drop a broken #if 0 /* optional */ piece of code2023-04-18T08:17:49+00:00tb2023-04-18T08:17:49+00:00urn:sha1:87b9736b2a0fa7d88c9287a2aa1bcc757372e73c
This places a point at infinity and then fails. Fix some wacky indentation
in the vicinity.
ec_point_conversion: drop test for sect571k12023-04-18T08:05:18+00:00tb2023-04-18T08:05:18+00:00urn:sha1:42fa556f70e00f4b863280d529915d25ce4dad17
Maybe it should be replaced by another test, although P-256 seems enough.