openbsd/src/usr.bin/openssl/pkcs12.c, branch OPENBSD_7_9_BASEA mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=OPENBSD_7_9_BASE2025-11-27T08:26:32+00:00openssl pkcs12: stop reaching into ASN1_STRING2025-11-27T08:26:32+00:00tb2025-11-27T08:26:32+00:00urn:sha1:e301ef23b53cd30d97d07468d49ce25c85bdea3e
Buy a t: rename hex_prin() to hex_print() and accept an ASN1_STRING so that
we only need to use accessors once. Also avoid a printf %s NULL.
ok kenjiro
KNF for variations of get_cipher_by_name()2025-06-07T08:33:58+00:00tb2025-06-07T08:33:58+00:00urn:sha1:adb6a70429b1c400ee9464123d7a5f10313c1b36Plug a bunch of leaks in the PKCS 12 code2024-12-26T14:10:48+00:00tb2024-12-26T14:10:48+00:00urn:sha1:b9d48b94b2b1f8938e4646a672cff8ea009964be
The competition whether the code or the standard it implements is worse
is still ongoing, and still has two strong competitors...
ok jsing
openssl pkcs12: remove support for LMK and CSP attributes2024-08-22T12:14:33+00:00tb2024-08-22T12:14:33+00:00urn:sha1:ebf266e10e4810d93b1809cc215996a75011f796
Documentation on what the Microsoft-specific local machine keyset and the
cryptographic service provider are actually good for is hard to find. For
some reason (perhaps one million and two arguments for PKCS12_create() was
considered two too many) these hang off the EVP_PKEY in the attributes
member, which serves no other purpose.
Every use of EVP_PKEY (of which there are far too many) pays extra memory
taxes for this fringe use case. This complication is not worth it.
ok miod
Expand only ever user of PBEPARAM_free() outside of libcrypto2024-02-28T17:04:38+00:00tb2024-02-28T17:04:38+00:00urn:sha1:053b93fb0b7bcd14494f84247e51bcaa2ec45a1aopenssl pkcs12: rewrite without reaching into X509_ALGOR2023-11-19T09:29:11+00:00tb2023-11-19T09:29:11+00:00urn:sha1:6e435e2554505c1ea973526a30fea9135b019f4f
We can call ASN1_item_unpack() which will end up stuffing the same
arguments into ASN1_item_d2i() as d2i_PBEPARAM(). This eliminates
the last struct access into X509_ALGOR outside libcrypto in the base
tree.
ok jsing
Rename struct ${app}_config to plain cfg2023-03-06T14:32:06+00:00tb2023-03-06T14:32:06+00:00urn:sha1:2ba7dcfcbc2ef5aaeb8eb14f36f83bd57c22bcae
All the structs are static and we need to reach into them many times.
Having a shorter name is more concise and results in less visual clutter.
It also avoids many overlong lines and we will be able to get rid of some
unfortunate line wrapping down the road.
Discussed with jsing
Remove the legacy interactive mode from openssl(1).2022-11-11T17:07:39+00:00joshua2022-11-11T17:07:39+00:00urn:sha1:273d9e16fc9e481283c2b2302b348e4863e29f28
This removes the legacy interactive mode from openssl(1) since it is
rarely used, complicates the code, and has also been removed from
OpenSSL in version 3.x.x.
ok tb@ jsing@
remove an extraneous empty line2022-09-14T16:31:36+00:00tb2022-09-14T16:31:36+00:00urn:sha1:b90fb1a563a5bd5fbe53dc5355f9de11f4dd687eAdjust for opaque structs in pkcs12.h2022-09-11T18:07:46+00:00tb2022-09-11T18:07:46+00:00urn:sha1:40113eb39e43ecfaa2a05e210c2d61610a1a5110
ok jsing