openbsd/src/usr.bin/openssl/s_client.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2020-07-10T12:25:57+00:00 Clean up s_client.c 2020-07-10T12:25:57+00:00 inoguchi 2020-07-10T12:25:57+00:00 urn:sha1:3c6fde5ba6eb2bfbc98636cddb732de46e207574 - Remove space between '*' and pointer variable. - Add function prototype. - Move callback function to bottom. - Move typedef struct to up. Change variable bio_c_out from global to local 2020-07-10T12:05:52+00:00 inoguchi 2020-07-10T12:05:52+00:00 urn:sha1:5b481640e2db6e61ad8d1123b0000711d318d127 ok tb@ Wrap long lines and put space in front of label in s_client.c 2020-07-09T14:09:19+00:00 inoguchi 2020-07-09T14:09:19+00:00 urn:sha1:ac1764813f3066545b1d343ee90ff5e8b5a1738b Remove c_ prefix from s_client_config member 2020-07-09T13:07:46+00:00 inoguchi 2020-07-09T13:07:46+00:00 urn:sha1:214992a8f72de0281fffb0f8c37067b79d50232d Convert openssl(1) s_client option handling 2020-07-09T12:48:19+00:00 inoguchi 2020-07-09T12:48:19+00:00 urn:sha1:bad3bb3e05c9313a4bb86df1c1b642371eddec03 suggestions and ok beck@ jsing@ tb@ In ssl_lib.c revision 1.217, jsing enabled SSL_MODE_AUTO_RETRY by 2020-05-23T12:52:54+00:00 tb 2020-05-23T12:52:54+00:00 urn:sha1:7f32076794cf53c4cba481f25dd750539030b92b default. To avoid hanging on a blocking read, we need to clear the SSL_MODE_AUTO_RETRY flag in the s_client and the s_server. ok beck inoguchi jsing sockaddr should be sockaddr_storage, otherwise "openssl s_client -6 -dtls1" 2020-05-22T16:11:23+00:00 deraadt 2020-05-22T16:11:23+00:00 urn:sha1:b252d4c293dcc14a07d6eff59aab97e224d207b2 (gurn) copies getsockname() retrieves a truncated result and 14 bytes of stack garbage get copied onwards. ok tb s_client: fix use of possibly uninitialized values 2020-04-26T01:59:27+00:00 inoguchi 2020-04-26T01:59:27+00:00 urn:sha1:6325635c2c2bd009b1451c06e5708ab404fc3ffa Set initial value to variable 'p' and 'pending'. Reported and fix requested from leonklingele by GitHub pull request. https://github.com/libressl-portable/portable/issues/577 https://github.com/libressl-portable/openbsd/pull/114 ok bcook@ jsing@ tb@ Add -groups option to openssl(1) s_server. 2020-04-19T17:05:55+00:00 jsing 2020-04-19T17:05:55+00:00 urn:sha1:fab181bd11bd26ebdc8c777b21768f05fcc6d7e1 This allows supported EC groups to be configured, which will also control which TLSv1.3 key shares we'll accept. While here, deprecate the rather useless -named_curve option, which is effectively the same as -groups with a single group. Also stop setting a single default group of P-256 via SSL_CTX_set_tmp_ecdh() - use the library defaults instead. ok beck@ inoguchi@ Add -tls1_3 and -notls1_3 options to openssl(1) s_client. 2020-02-16T16:39:01+00:00 jsing 2020-02-16T16:39:01+00:00 urn:sha1:0247fea12677c0df2e4e2fa695e67807aa9ea241 Also stop using version pinned methods, instead setting the min and max protocol versions. Requested by inoguchi@ ok inoguchi@ tb@