openbsd/src/usr.bin/openssl/s_time.c, branch OPENBSD_6_8_BASE A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=OPENBSD_6_8_BASE 2019-07-14T03:30:46+00:00 Mark the initialized struct options arrays as both static and const. 2019-07-14T03:30:46+00:00 guenther 2019-07-14T03:30:46+00:00 urn:sha1:ce9daaa0080f6ec467441aa485eb3f11ad6fb74a This moves them from .data to .data.rel.ro ok deraadt@ inoguchi@ snprintf/vsnprintf return < 0 on error, rather than -1. 2019-07-03T03:24:04+00:00 deraadt 2019-07-03T03:24:04+00:00 urn:sha1:bdd1c0627cbfd4015db19da84ab1a24f50d9f6dc Move tally mark printing out of the main benchmark loop; ok tb@ 2018-09-17T15:37:35+00:00 cheloha 2018-09-17T15:37:35+00:00 urn:sha1:e151a5a4b932becd5053c3b0d892162ddce644a7 Drop SSLv2, SSLv3 support. 2018-08-28T14:30:48+00:00 cheloha 2018-08-28T14:30:48+00:00 urn:sha1:77e1ea8bb9aa1cecb177100ea28b91f0c61d7a18 No need to check for SSLv2/3 sessions when printing the tally mark. Also do SSLv23_client_method -> TLS_client_method. ok jsing@ Check for SSL_write(3) error. 2018-08-28T02:14:22+00:00 cheloha 2018-08-28T02:14:22+00:00 urn:sha1:47c7a81989b6ae45dcc149174f78c3487c2b3c3f jsing@ notes that this is not a complete solution, as we don't account for retries or partial writes, but that this is a step in a right direction. May want to revisit this later to provide a complete solution. ok jsing@ Use a monotonic clock for the benchmark timeout. 2018-08-22T20:36:24+00:00 cheloha 2018-08-22T20:36:24+00:00 urn:sha1:c297504adf8051e25fdb0460d606152be7ced86c While here, we don't need the app_timer_* wrapper function, it only obfuscates things, so delete it. Also while here, totalTime only needs to be assigned once. ok tb@ Merge duplicate benchmark() GET/SSL_shutdown blocks into doConnection(). 2018-08-21T15:56:39+00:00 cheloha 2018-08-21T15:56:39+00:00 urn:sha1:99b3497d8044797c6e3fdd4f8c329dabd2872897 We need to then remove the shadow i from the GET block. While there, move retval's declaration to the beginning of the function. As doConnection() now executes the body of the benchmark's test, rename it to "run_test". Shadow variable spotted by tb@. ok tb@ Plug SSL object leaks in doConnection(). 2018-08-18T16:51:33+00:00 cheloha 2018-08-18T16:51:33+00:00 urn:sha1:bcdd4b48a5254c1ea134faccbe9d9ad563470117 Move SSL_new/SSL_free up into benchmark() to restrict the responsibility for the SSL object to a single scope. Make doConnection() return an int, openssl-style. Some miscellaneous cleanup, too. Discussed with tb, jsing, and jca. Basic idea from jsing, lots of patch input from tb. ok deraadt on an earlier version ok tb jsing Don't fail by default in the -new case; ok tb jca 2018-08-14T15:25:04+00:00 cheloha 2018-08-14T15:25:04+00:00 urn:sha1:fd0fe048aba73cca22d3220f299f765d414cb211 Refactor the nearly identical benchmark loops into a single loop. 2018-08-11T16:07:36+00:00 cheloha 2018-08-11T16:07:36+00:00 urn:sha1:3bdf42f49f445f33cfe8ce9261d1504d89474682 Move all of the benchmark code -- loop initialization, the loops, and the report printing -- into a new function, benchmark(). Eliminates lots of duplicate code. Regressions to 1.20 caught by tb@ and inoguchi@. Tweaked by tb@. ok tb@, jsing@