openbsd/src, branch libressl-v3.1.0 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.1.0 2020-03-30T12:52:58+00:00 "eventually" came and went back in 2004. 2020-03-30T12:52:58+00:00 martijn 2020-03-30T12:52:58+00:00 urn:sha1:f9d22e5bfb4a68abbe135cdcad92967c8344714c OK schwarze@ Void functions obviously do not return values; no need to elaborate. 2020-03-30T10:28:59+00:00 schwarze 2020-03-30T10:28:59+00:00 urn:sha1:4453211b1bc50f16a0dac3b8c66e63b25afc65cf Patch from Martin Vahlensieck <academicsolutions dot ch>. Void functions obviously do not return values; no need to elaborate. 2020-03-29T17:05:02+00:00 schwarze 2020-03-29T17:05:02+00:00 urn:sha1:f380a0425155bb24efdb8ed8a5472375889c8ed4 Patch from Martin Vahlensieck <academicsolutions dot ch>. Be concise: do not say that void functions return no values, that's obvious. 2020-03-28T22:40:58+00:00 schwarze 2020-03-28T22:40:58+00:00 urn:sha1:f3775b337cafc42fea310ef0fd85720ffffe009e Useless text reported by Martin Vahlensieck (academicsolutions.ch) on tech@. Fix ASN1 print functions 2020-03-24T10:46:38+00:00 inoguchi 2020-03-24T10:46:38+00:00 urn:sha1:eacf3461605a07f186ea238b0a1a1a26cf1aa9ea Check and print out boolean type properly. Based on OpenSSL commit ad72d9fdf7709ddb97a58d7d45d755e6e0504b96. Reduced unneeded parentheses from if condition. Check return value from i2s_ASN1_INTEGER. Based on OpenSSL commit 5e3553c2de9a365479324b8ba8b998f0cce3e527. Added if condition expression and return 0 if NULL is returned. ok tb@ Add a test program for getopt(3) that is adequate for manual testing 2020-03-23T03:01:21+00:00 schwarze 2020-03-23T03:01:21+00:00 urn:sha1:73c41a1f3bbb8dc00bd6d35c879e88ee6d1922b9 and a compact test suite for getopt(3) intended automated regression testing, both written from scratch. The suite is intended to provide full coverage, except that it doesn't test manual changes of optind and optreset and except that it so far avoids the situation where we have a known bug. Consistently spell 'unsigned' as 'unsigned int', as style(9) seems 2020-03-16T15:25:14+00:00 tb 2020-03-16T15:25:14+00:00 urn:sha1:168e0561df78f7340b3a674c6ffe771fb5b4bbb2 to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing Adapt to tls13_record_layer.c r1.30 (the sequence number shouldn't wrap). 2020-03-16T15:13:15+00:00 tb 2020-03-16T15:13:15+00:00 urn:sha1:a62e6b1fd543a8a4f66031fcba26c09016ee6299 The RFC is clear (section 5.3) that sequence number should never wrap. 2020-03-16T15:11:35+00:00 tb 2020-03-16T15:11:35+00:00 urn:sha1:32be1a54d46e2dd4e81e6aa7ba36eec513f5833f We currently throw an error on overflow, but still wrap. Check up front if we would need to wrap and only increment if that case is excluded. This simplifies the increment loop and makes the returns in this function less magic. ok jsing Increment a few more sequence numbers where the carry is close to 2020-03-13T17:47:38+00:00 tb 2020-03-13T17:47:38+00:00 urn:sha1:106f32938eaf7e2baa136e46129f9e5c8888ece6 crossing a byte boundary.