openbsd/src, branch libressl-v3.3.1 A mirror of https://github.com/libressl/openbsd.git https://git.lua4.win/openbsd/atom?h=libressl-v3.3.1 2020-12-08T17:39:06+00:00 LibreSSL 3.3.1 2020-12-08T17:39:06+00:00 bcook 2020-12-08T17:39:06+00:00 urn:sha1:3a8e5b1810653b07037a5ff1e5b46554bb430ac2 Fix a NULL dereference in GENERAL_NAME_cmp() 2020-12-08T15:06:42+00:00 tb 2020-12-08T15:06:42+00:00 urn:sha1:9b6213a4c1c3792c23b8d5da5d4d7ef1cae15e50 Comparing two GENERAL_NAME structures containing an EDIPARTYNAME can lead to a crash. This enables a denial of service attack for an attacker who can control both sides of the comparison. Issue reported to OpenSSL on Nov 9 by David Benjamin. OpenSSL shared the information with us on Dec 1st. Fix from Matt Caswell (OpenSSL) with a few small tweaks. ok jsing Enable t_mmap-1 test. It is skipped on NetBSD, but works for us. 2020-12-06T18:46:07+00:00 bluhm 2020-12-06T18:46:07+00:00 urn:sha1:44baf3722b2a45a27cba7695d8a2f00a965c973e Mark bitmask_{start,end}_values[] and g_probable_mtu[] const. 2020-12-05T19:34:57+00:00 tb 2020-12-05T19:34:57+00:00 urn:sha1:e15b4af220e429099aba832b31f097b2916d19e8 ok jsing kn Mark nid_list[] const. This moves 116 bytes to .rodata. 2020-12-05T19:33:38+00:00 tb 2020-12-05T19:33:38+00:00 urn:sha1:8c0f6308a96a26238a44856da0cb53a3cb54bbf2 ok jsing kn Move point-on-curve check to set_affine_coordinates 2020-12-04T08:55:30+00:00 tb 2020-12-04T08:55:30+00:00 urn:sha1:19beb136cce42fbe56d004577d27ddc0ca69f793 Bad API design makes it possible to set an EC_KEY public key to a point not on the curve. As a consequence, it was possible to have bogus ECDSA signatures validated. In practice, all software uses either EC_POINT_oct2point*() to unmarshal public keys or issues a call to EC_KEY_check_key() after setting it. This way, a point on curve check is performed and the problem is mitigated. In OpenSSL commit 1e2012b7ff4a5f12273446b281775faa5c8a1858, Emilia Kasper moved the point-on-curve check from EC_POINT_oct2point to EC_POINT_set_affine_coordinates_*, which results in more checking. In addition to this commit, we also check in the currently unused codepath of a user set callback for setting compressed coordinates, just in case this will be used at some point in the future. The documentation of EC_KEY_check_key() is very vague on what it checks and when checks are needed. It could certainly be improved a lot. It's also strange that EC_KEY_set_key() performs no checks, while EC_KEY_set_public_key_affine_coordinates() implicitly calls EC_KEY_check_key(). It's a mess. Issue found and reported by Guido Vranken who also tested an earlier version of this fix. ok jsing grammar fixes from Varik "The Genuine Article!!!" Valefor; 2020-12-03T22:47:22+00:00 jmc 2020-12-03T22:47:22+00:00 urn:sha1:bf90c7348aa11c405e8d6a2e0bceeb937623d4b8 Extend the methods test to cover dtls methods as well 2020-12-01T08:05:06+00:00 tb 2020-12-01T08:05:06+00:00 urn:sha1:cc8d6bebaa644793e32cf2685b91ea0ee9e2fb8e Enable ssl_methods unit test. 2020-12-01T07:49:03+00:00 tb 2020-12-01T07:49:03+00:00 urn:sha1:d71547747eecf63b234136f4e4f7869a7ee3a570 Add an ssl_methods() unit test that currently only covers the 2020-12-01T07:48:35+00:00 tb 2020-12-01T07:48:35+00:00 urn:sha1:4850bbd0ed9b1a6b64356dde6064041385143b51 behavior of SSL_is_server(). This would have caught the regression introduced in the method unification.