openbsd/src, branch tb_20230422A mirror of https://github.com/libressl/openbsd.git
https://git.lua4.win/openbsd/atom?h=tb_202304222023-04-23T13:43:47+00:00This commit was manufactured by cvs2git to create tag 'tb_20230422'.2023-04-23T13:43:47+00:00cvs2svnadmin@example.com2023-04-23T13:43:47+00:00urn:sha1:e2496982472bdf233be95c5ea72d1c4dc6c91db3Import C2SP/CCTV test2023-04-23T13:43:46+00:00tb2023-04-23T13:43:46+00:00urn:sha1:097d0cf840b9007212bcd2516ed5e18939e6da3d
This currently only covers Ed25519 using the c2sp-testvectors package
and checks that our Ed25519 implementation behaves as expected from a
"ref10" implementation.
This test has Go and c2sp-testvectors as a hard dependency. It will
optionally pick up any OpenSSL package installed on the system and
test that as well.
https://github.com/C2SP/CCTV
https://github.com/C2SP/CCTV/tree/main/ed25519
Drop some extra parentheses2023-04-23T11:52:14+00:00tb2023-04-23T11:52:14+00:00urn:sha1:3999ba491ccd1196e93f475303269b93430209faDrop a superfluous isneg check.2023-04-23T11:39:56+00:00tb2023-04-23T11:39:56+00:00urn:sha1:a144bab8654472b756f3b2973465b9c89b2f56a2Add missing NULL check for BN_new()2023-04-23T11:34:57+00:00tb2023-04-23T11:34:57+00:00urn:sha1:ff36f25f7ccd3f6edb9f06c26f12c96a19847c09Initialize ishex and isneg at the top and drop some elses2023-04-23T11:25:21+00:00tb2023-04-23T11:25:21+00:00urn:sha1:0d736aa8eb426f9e1fb0c6e8fa09cb32effd7f7fAlign hex_to_string with OpenSSL 1.1 behavior2023-04-23T10:19:52+00:00tb2023-04-23T10:19:52+00:00urn:sha1:a77795d252b58fa4bbaf3beec1fa1dac50f6785c
This is a bit of a strange one. When this function was moved and renamed,
somehow checks for NULL pointers and 0 length were lost. Whether that was
due to great review missing it or great review suggesting it, is unclear.
Now the function can actually legitimately be called with a length of 0
(as ASN.1 OCTET STRINGS can have length 0) and "" is the appropriate
representation for that, so the fix is to allocate a 0 octet. That much
was correct. What was completely missed is that a long can be negative
which will then still lead to an out-of-bounds access. So fix that as
well.
Finally, don't malloc 3 * len + 1 without overflow checking. Rather
use calloc's internal checks. The + 1 isn't really needed anyway.
All this is still really gross and can be done much more cleanly and
safely with CBB/CBS. This will done later once we have better regress
coverage.
ok jsing
x509_utl.c: Use correct spelling of NULL2023-04-23T09:58:38+00:00tb2023-04-23T09:58:38+00:00urn:sha1:096877f0408128467e9955e510bce04c2d583bf4Document the change in default to comma plus space but leave out the2023-04-22T20:51:26+00:00tb2023-04-22T20:51:26+00:00urn:sha1:2819c5437943380fd9efa49aa984dc506ceb8bbe
compat nonsense
Fix UTF-8 issuer printing2023-04-22T20:50:26+00:00tb2023-04-22T20:50:26+00:00urn:sha1:11825ca98103ac2b6c1991895202722b4cc3cf55
If no field separator is specified, default to using the comma plus space
separation, unless the compat flag is set.
Fixes an a bug with printing issuers and other things that contain UTF-8
Reported by Jean-Luc Duprat
The very simple fix ix is a joint effort by Henson and Levitte
Fixes libressl/portable issue #845
ok jsing