diff options
| author | jsing <> | 2014-10-18 16:13:16 +0000 |
|---|---|---|
| committer | jsing <> | 2014-10-18 16:13:16 +0000 |
| commit | c7ab256a26b40c83b42c202488c01636a208c01c (patch) | |
| tree | 0ec0407532b236ff11b9134f214f8db715d84e63 /src/lib/libcrypto/dh/dh_key.c | |
| parent | dd127b6b5a62ebd88f0cbb2e6d7d749d20363a16 (diff) | |
| download | openbsd-c7ab256a26b40c83b42c202488c01636a208c01c.tar.gz openbsd-c7ab256a26b40c83b42c202488c01636a208c01c.tar.bz2 openbsd-c7ab256a26b40c83b42c202488c01636a208c01c.zip | |
Use arc4random_buf() instead of RAND_bytes() or RAND_pseudo_bytes().
arc4random provides high quality pseudo-random numbers, hence there is no
need to differentiate between "strong" and "pseudo". Furthermore, the
arc4random_buf() function is guaranteed to succeed, which avoids the need
to check for and handle failure, simplifying the code.
It is worth noting that a number of the replaced RAND_bytes() and
RAND_pseudo_bytes() calls were missing return value checks and these
functions can fail for a number of reasons (at least in OpenSSL -
thankfully they were converted to wrappers around arc4random_buf() some
time ago in LibreSSL).
ok beck@ deraadt@ miod@
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions