DSA_SIG_new() amounts to a single calloc() call.

ok beck@ tb@

1 files changed, 3 insertions, 10 deletions

diff --git a/src/lib/libcrypto/dsa/dsa_sign.c b/src/lib/libcrypto/dsa/dsa_sign.c
index 355bdd20d6..0f55ea1868 100644
--- a/src/lib/libcrypto/dsa/dsa_sign.c
+++ b/src/lib/libcrypto/dsa/dsa_sign.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: dsa_sign.c,v 1.19 2014/10/18 17:20:40 jsing Exp $ */
+/* $OpenBSD: dsa_sign.c,v 1.20 2018/06/14 17:01:49 jsing Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -76,20 +76,13 @@ DSA_sign_setup(DSA *dsa, BN_CTX *ctx_in, BIGNUM **kinvp, BIGNUM **rp)
 DSA_SIG *
 DSA_SIG_new(void)
 {
-        DSA_SIG *sig;
-
-        sig = malloc(sizeof(DSA_SIG));
-        if (!sig)
-                return NULL;
-        sig->r = NULL;
-        sig->s = NULL;
-        return sig;
+        return calloc(1, sizeof(DSA_SIG));
 }
 
 void
 DSA_SIG_free(DSA_SIG *sig)
 {
-        if (sig) {
+        if (sig != NULL) {
                 BN_free(sig->r);
                 BN_free(sig->s);
                 free(sig);