Garbage collect xobj->data.{ptr,pkey}

Both these are essentially unused. Remove the last use of data.ptr
by initializing and copying the X509_OBJECT using memset() and
struct assignment in X509_STORE_CTX_get_subject_by_name() and add
a missing error check for X509_OBJECT_up_ref_count() while there.

ok beck

1 files changed, 0 insertions, 2 deletions

diff --git a/src/lib/libcrypto/x509/x509_lcl.h b/src/lib/libcrypto/x509/x509_lcl.h
index 804fff48fc..e1894e5523 100644
--- a/src/lib/libcrypto/x509/x509_lcl.h
+++ b/src/lib/libcrypto/x509/x509_lcl.h
@@ -246,10 +246,8 @@ struct x509_object_st {
         /* one of the above types */
         int type;
         union {
-                char *ptr;
                 X509 *x509;
                 X509_CRL *crl;
-                EVP_PKEY *pkey;
         } data;
 } /* X509_OBJECT */;