diff options
| author | doug <> | 2014-10-18 03:04:28 +0000 |
|---|---|---|
| committer | doug <> | 2014-10-18 03:04:28 +0000 |
| commit | 4c6f8c571ce55eaa0d8cf775bcc329734429e32d (patch) | |
| tree | 1bf60bebcb5a98e250f1d744bbcac5074ab7dd3c /src/lib/libssl/t1_enc.c | |
| parent | 8747be219317523dad19052f621a3d2ff3f1f599 (diff) | |
| download | openbsd-4c6f8c571ce55eaa0d8cf775bcc329734429e32d.tar.gz openbsd-4c6f8c571ce55eaa0d8cf775bcc329734429e32d.tar.bz2 openbsd-4c6f8c571ce55eaa0d8cf775bcc329734429e32d.zip | |
Typical malloc() with size multiplication to reallocarray().
ok deraadt@
Diffstat (limited to 'src/lib/libssl/t1_enc.c')
| -rw-r--r-- | src/lib/libssl/t1_enc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/libssl/t1_enc.c b/src/lib/libssl/t1_enc.c index 6ad721bd8a..a62d7a939c 100644 --- a/src/lib/libssl/t1_enc.c +++ b/src/lib/libssl/t1_enc.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: t1_enc.c,v 1.69 2014/08/07 20:02:23 miod Exp $ */ | 1 | /* $OpenBSD: t1_enc.c,v 1.70 2014/10/18 03:04:28 doug Exp $ */ |
| 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
| 3 | * All rights reserved. | 3 | * All rights reserved. |
| 4 | * | 4 | * |
| @@ -603,14 +603,14 @@ tls1_setup_key_block(SSL *s) | |||
| 603 | s->s3->tmp.new_mac_pkey_type = mac_type; | 603 | s->s3->tmp.new_mac_pkey_type = mac_type; |
| 604 | s->s3->tmp.new_mac_secret_size = mac_secret_size; | 604 | s->s3->tmp.new_mac_secret_size = mac_secret_size; |
| 605 | 605 | ||
| 606 | key_block_len = (mac_secret_size + key_len + iv_len) * 2; | ||
| 607 | |||
| 608 | ssl3_cleanup_key_block(s); | 606 | ssl3_cleanup_key_block(s); |
| 609 | 607 | ||
| 610 | if ((key_block = malloc(key_block_len)) == NULL) { | 608 | if ((key_block = reallocarray(NULL, mac_secret_size + key_len + iv_len, |
| 609 | 2)) == NULL) { | ||
| 611 | SSLerr(SSL_F_TLS1_SETUP_KEY_BLOCK, ERR_R_MALLOC_FAILURE); | 610 | SSLerr(SSL_F_TLS1_SETUP_KEY_BLOCK, ERR_R_MALLOC_FAILURE); |
| 612 | goto err; | 611 | goto err; |
| 613 | } | 612 | } |
| 613 | key_block_len = (mac_secret_size + key_len + iv_len) * 2; | ||
| 614 | 614 | ||
| 615 | s->s3->tmp.key_block_length = key_block_len; | 615 | s->s3->tmp.key_block_length = key_block_len; |
| 616 | s->s3->tmp.key_block = key_block; | 616 | s->s3->tmp.key_block = key_block; |
