diff options
| author | tedu <> | 2014-06-04 14:10:23 +0000 |
|---|---|---|
| committer | tedu <> | 2014-06-04 14:10:23 +0000 |
| commit | d492661281c20abc5a3d96742866e0d1e698192a (patch) | |
| tree | 2239b639d15116fcc235465d6e2d18383e6f7ce1 /src/lib/libssl/t1_reneg.c | |
| parent | cb4fd7a5079a34d011180ce6d23a7730cbed57e5 (diff) | |
| download | openbsd-d492661281c20abc5a3d96742866e0d1e698192a.tar.gz openbsd-d492661281c20abc5a3d96742866e0d1e698192a.tar.bz2 openbsd-d492661281c20abc5a3d96742866e0d1e698192a.zip | |
without overthinking it, replace a few memcmp calls with CRYPTO_memcmp
where it is feasible to do so. better safe than sorry.
Diffstat (limited to '')
| -rw-r--r-- | src/lib/libssl/t1_reneg.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/lib/libssl/t1_reneg.c b/src/lib/libssl/t1_reneg.c index 5f96e1fa7e..c9e0704c07 100644 --- a/src/lib/libssl/t1_reneg.c +++ b/src/lib/libssl/t1_reneg.c | |||
| @@ -172,7 +172,7 @@ ssl_parse_clienthello_renegotiate_ext(SSL *s, unsigned char *d, int len, | |||
| 172 | return 0; | 172 | return 0; |
| 173 | } | 173 | } |
| 174 | 174 | ||
| 175 | if (memcmp(d, s->s3->previous_client_finished, | 175 | if (CRYPTO_memcmp(d, s->s3->previous_client_finished, |
| 176 | s->s3->previous_client_finished_len)) { | 176 | s->s3->previous_client_finished_len)) { |
| 177 | SSLerr(SSL_F_SSL_PARSE_CLIENTHELLO_RENEGOTIATE_EXT, | 177 | SSLerr(SSL_F_SSL_PARSE_CLIENTHELLO_RENEGOTIATE_EXT, |
| 178 | SSL_R_RENEGOTIATION_MISMATCH); | 178 | SSL_R_RENEGOTIATION_MISMATCH); |
| @@ -259,7 +259,7 @@ ssl_parse_serverhello_renegotiate_ext(SSL *s, unsigned char *d, int len, | |||
| 259 | return 0; | 259 | return 0; |
| 260 | } | 260 | } |
| 261 | 261 | ||
| 262 | if (memcmp(d, s->s3->previous_client_finished, | 262 | if (CRYPTO_memcmp(d, s->s3->previous_client_finished, |
| 263 | s->s3->previous_client_finished_len)) { | 263 | s->s3->previous_client_finished_len)) { |
| 264 | SSLerr(SSL_F_SSL_PARSE_SERVERHELLO_RENEGOTIATE_EXT, | 264 | SSLerr(SSL_F_SSL_PARSE_SERVERHELLO_RENEGOTIATE_EXT, |
| 265 | SSL_R_RENEGOTIATION_MISMATCH); | 265 | SSL_R_RENEGOTIATION_MISMATCH); |
| @@ -268,7 +268,7 @@ ssl_parse_serverhello_renegotiate_ext(SSL *s, unsigned char *d, int len, | |||
| 268 | } | 268 | } |
| 269 | d += s->s3->previous_client_finished_len; | 269 | d += s->s3->previous_client_finished_len; |
| 270 | 270 | ||
| 271 | if (memcmp(d, s->s3->previous_server_finished, | 271 | if (CRYPTO_memcmp(d, s->s3->previous_server_finished, |
| 272 | s->s3->previous_server_finished_len)) { | 272 | s->s3->previous_server_finished_len)) { |
| 273 | SSLerr(SSL_F_SSL_PARSE_SERVERHELLO_RENEGOTIATE_EXT, | 273 | SSLerr(SSL_F_SSL_PARSE_SERVERHELLO_RENEGOTIATE_EXT, |
| 274 | SSL_R_RENEGOTIATION_MISMATCH); | 274 | SSL_R_RENEGOTIATION_MISMATCH); |
